From bb5f12d3154d2543a873db45efe7ce14b1d0b4bf Mon Sep 17 00:00:00 2001 From: Laminas Bot Date: Mon, 7 Dec 2020 18:47:19 +0000 Subject: [PATCH 1/3] Bumps changelog version to 3.4.4 Updates the CHANGELOG.md file to add a changelog entry for a new 3.4.4 version. --- CHANGELOG.md | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 813f484..ad94a05 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,28 @@ All notable changes to this project will be documented in this file, in reverse chronological order by release. +## 3.4.4 - TBD + +### Added + +- Nothing. + +### Changed + +- Nothing. + +### Deprecated + +- Nothing. + +### Removed + +- Nothing. + +### Fixed + +- Nothing. + ## 3.4.3 - 2020-12-07 From c9215b0182a00e3741cad675fa1478b8fa25d527 Mon Sep 17 00:00:00 2001 From: Gregor Kralik Date: Fri, 11 Dec 2020 12:02:26 +0100 Subject: [PATCH 2/3] cast to string when calling rawurlencode() within Wildcard router Signed-off-by: Gregor Kralik --- src/Http/Wildcard.php | 2 +- test/Http/WildcardTest.php | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Http/Wildcard.php b/src/Http/Wildcard.php index 7c7856d..c93ed39 100644 --- a/src/Http/Wildcard.php +++ b/src/Http/Wildcard.php @@ -175,7 +175,7 @@ public function assemble(array $params = [], array $options = []) continue; } - $elements[] = rawurlencode($key) . $this->keyValueDelimiter . rawurlencode($value); + $elements[] = rawurlencode($key) . $this->keyValueDelimiter . rawurlencode((string) $value); $this->assembledParams[] = $key; } diff --git a/test/Http/WildcardTest.php b/test/Http/WildcardTest.php index 1e7bbcd..c3c0c93 100644 --- a/test/Http/WildcardTest.php +++ b/test/Http/WildcardTest.php @@ -83,6 +83,12 @@ public static function routeProvider() null, ['foo' => 'foo bar'] ], + 'params-contain-non-string-scalar-values' => [ + new Wildcard(), + '/int_param/42/float_param/4.2', + null, + ['int_param' => 42, 'float_param' => 4.2] + ], ]; } From 2a7068508af4de67d80ea292e0cc7c37563a33c6 Mon Sep 17 00:00:00 2001 From: Laminas Bot Date: Wed, 16 Dec 2020 22:10:51 +0000 Subject: [PATCH 3/3] 3.4.4 readiness Updates the CHANGELOG.md to set the release date. --- CHANGELOG.md | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ad94a05..5792580 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,27 +2,24 @@ All notable changes to this project will be documented in this file, in reverse chronological order by release. -## 3.4.4 - TBD +## 3.4.4 - 2020-12-16 -### Added - -- Nothing. - -### Changed -- Nothing. +----- -### Deprecated +### Release Notes for [3.4.4](https://github.com/laminas/laminas-router/milestone/8) -- Nothing. +3.4.x bugfix release (patch) -### Removed +### 3.4.4 -- Nothing. +- Total issues resolved: **1** +- Total pull requests resolved: **1** +- Total contributors: **1** -### Fixed +#### Bug -- Nothing. + - [24: cast to string when calling rawurlencode() within Wildcard router](https://github.com/laminas/laminas-router/pull/24) thanks to @gkralik ## 3.4.3 - 2020-12-07