Skip to content

Add showLoadingAfterInitialLoad prop #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dextermb
Copy link
Contributor

@dextermb dextermb commented Apr 7, 2019

Closes #35

@DivineOmega
Copy link
Contributor

I like the functionality and implementation. 👍

I'm trying to think if there is a simpler prop name we can use. What are your thought on the following?

  • onlyShowLoadingOnce
  • onlyLoadOnce
  • initialLoadingOnly
  • showLoadingOnce
  • onlyDisplayLoadingOnce

I think onlyShowLoadingOnce is perhaps the clearest.

@dextermb
Copy link
Contributor Author

dextermb commented Apr 8, 2019

I like the functionality and implementation. 👍

I'm trying to think if there is a simpler prop name we can use. What are your thought on the following?

  • onlyShowLoadingOnce
  • onlyLoadOnce
  • initialLoadingOnly
  • showLoadingOnce
  • onlyDisplayLoadingOnce

I think onlyShowLoadingOnce is perhaps the clearest.

I think this one onlyLoadOnce is misleading, but onlyShowLoadingOnce could be updated.

@DivineOmega
Copy link
Contributor

I agree. Let's go with onlyShowLoadingOnce. You'll probably need to reverse the logic for it to make sense, as this prop name is linguistically opposite to the current one.

Default it to false to maintain the current behaviour.

Then feel free to bump the minor version number.

@DivineOmega
Copy link
Contributor

I would say document it, but of course this is a prop of the currently undocumented ajax component.

@dextermb
Copy link
Contributor Author

dextermb commented Apr 9, 2019

🚧 👷 I believe this is finally how you want it

DivineOmega
DivineOmega previously approved these changes Apr 9, 2019
@dextermb
Copy link
Contributor Author

dextermb commented Jul 9, 2019

@DivineOmega I have resolved merge conflicts and updated the version number to 6.1.0. This should be safe to approve and merge in again.

@dextermb dextermb closed this Apr 21, 2022
@dextermb dextermb deleted the feature/show-loading-after-initial-load-prop branch April 21, 2022 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not update the loading prop after the first page
2 participants