Skip to content

Update propTypes on DataRow to use valid prop type function #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dextermb opened this issue Oct 23, 2019 · 2 comments
Open

Update propTypes on DataRow to use valid prop type function #81

dextermb opened this issue Oct 23, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@dextermb
Copy link
Contributor

required should be isRequired as seen in the usage documentation for prop-types.

react-dynamic-data-table/src/Components/DataRow.jsx

Line 235 in 6b539d9

index: PropTypes.number.required,

@dextermb dextermb added the good first issue Good for newcomers label Oct 23, 2019
@DivineOmega
Copy link
Contributor

Good catch. I wonder why we've not noticed that warning up until now.

@dextermb
Copy link
Contributor Author

Good catch. I wonder why we've not noticed that warning up until now.

Probably only used previous versions of the datatable until now in existing projects. It'll get resolved soon enough 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DivineOmega @dextermb