Skip to content

Commit 778921b

Browse files
committedNov 30, 2024·
fix: remove deprecation notices in php 8.4
1 parent 91e1286 commit 778921b

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed
 

‎.github/workflows/tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
fail-fast: true
1616
matrix:
17-
php: [8.2, 8.3]
17+
php: [8.2, 8.3, 8.4]
1818
laravel: [11]
1919

2020
steps:

‎CHANGELOG.md

+5-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,11 @@
33
All notable changes to this project will be documented in this file. This project adheres to
44
[Semantic Versioning](http://semver.org/) and [this changelog format](http://keepachangelog.com/).
55

6-
## Unreleased (Laravel 11)
6+
## Unreleased
7+
8+
### Fixed
9+
10+
- Remove deprecation notices in PHP 8.4.
711

812
## [4.0.0] - 2024-03-14
913

‎composer.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"illuminate/database": "^11.0",
2929
"illuminate/pagination": "^11.0",
3030
"illuminate/support": "^11.0",
31-
"laravel-json-api/eloquent": "^4.0"
31+
"laravel-json-api/eloquent": "^4.4"
3232
},
3333
"require-dev": {
3434
"orchestra/testbench": "^9.0",
@@ -51,7 +51,7 @@
5151
"dev-develop": "4.x-dev"
5252
}
5353
},
54-
"minimum-stability": "stable",
54+
"minimum-stability": "dev",
5555
"prefer-stable": true,
5656
"config": {
5757
"sort-packages": true

‎src/Cursor/Cursor.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ class Cursor
3838
* @param string|null $after
3939
* @param int|null $limit
4040
*/
41-
public function __construct(string $before = null, string $after = null, int $limit = null)
41+
public function __construct(?string $before = null, ?string $after = null, ?int $limit = null)
4242
{
4343
if (is_int($limit) && 1 > $limit) {
4444
throw new InvalidArgumentException('Expecting a limit that is 1 or greater.');

‎src/Cursor/CursorBuilder.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ class CursorBuilder
6565
* @param string|null $key
6666
* the key column that the before/after cursors related to.
6767
*/
68-
public function __construct($query, string $column = null, string $key = null)
68+
public function __construct($query, ?string $column = null, ?string $key = null)
6969
{
7070
if (!$query instanceof Builder && !$query instanceof Relation) {
7171
throw new InvalidArgumentException('Expecting an Eloquent query builder or relation.');

0 commit comments

Comments
 (0)
Please sign in to comment.