Skip to content

Commit 0e890e8

Browse files
committed
fix: remove deprecation notices in php 8.4
1 parent 9a229e5 commit 0e890e8

File tree

5 files changed

+9
-4
lines changed

5 files changed

+9
-4
lines changed

.github/workflows/tests.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ jobs:
1414
strategy:
1515
fail-fast: true
1616
matrix:
17-
php: [8.2, 8.3]
17+
php: [8.2, 8.3, 8.4]
1818
laravel: [11]
1919

2020
steps:

CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. This projec
55

66
## Unreleased
77

8+
### Fixed
9+
10+
- Remove deprecation notices for PHP 8.4.
11+
812
## [3.0.0] - 2024-03-12
913

1014
### Changed

composer.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
"ext-json": "*",
2828
"illuminate/contracts": "^11.0",
2929
"illuminate/pipeline": "^11.0",
30-
"laravel-json-api/core": "^4.0",
31-
"laravel-json-api/validation": "^4.0"
30+
"laravel-json-api/core": "^4.3.2",
31+
"laravel-json-api/validation": "^4.2"
3232
},
3333
"require-dev": {
3434
"laravel-json-api/testing": "^3.0",

phpunit.xml

+1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
failOnWarning="true"
1414
failOnDeprecation="true"
1515
failOnNotice="true"
16+
displayDetailsOnTestsThatTriggerDeprecations="true"
1617
>
1718
<coverage/>
1819
<testsuites>

src/Pipes/ValidationExceptionHandler.php

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ class ValidationExceptionHandler
3636
*/
3737
public function __construct(
3838
private readonly Factory $factory,
39-
Translator $translator = null,
39+
?Translator $translator = null,
4040
) {
4141
$this->translator = $translator;
4242
}

0 commit comments

Comments
 (0)