fix: remove deprecation notices in php 8.4

Author: lindyhopchris

.github/workflows/tests.yml

@@ -14,7 +14,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        php: [8.2, 8.3]
+        php: [8.2, 8.3, 8.4]
         laravel: [11]
 
     steps:

CHANGELOG.md

@@ -5,6 +5,10 @@ All notable changes to this project will be documented in this file. This projec
 
 ## Unreleased
 
+### Fixed
+
+- Removed deprecation notices in PHP 8.4.
+
 ## [3.0.0] - 2024-03-14
 
 ### Changed

composer.json

@@ -28,7 +28,7 @@
         "illuminate/contracts": "^11.0",
         "illuminate/pipeline": "^11.0",
         "illuminate/support": "^11.0",
-        "laravel-json-api/core": "^4.0"
+        "laravel-json-api/core": "^4.3.2"
     },
     "require-dev": {
         "orchestra/testbench": "^9.0",
@@ -54,7 +54,7 @@
             ]
         }
     },
-    "minimum-stability": "stable",
+    "minimum-stability": "dev",
     "prefer-stable": true,
     "config": {
         "sort-packages": true

phpunit.xml

@@ -13,6 +13,7 @@
          failOnWarning="true"
          failOnDeprecation="true"
          failOnNotice="true"
+         displayDetailsOnTestsThatTriggerDeprecations="true"
 >
   <coverage/>
   <testsuites>

src/Factory.php

@@ -51,7 +51,7 @@ public function __construct(Specification $spec, Translator $translator)
      *      the relation the identifier exists in.
      * @return Identifier
      */
-    public function createIdentifierValue(string $path, $value, Relation $relation = null): Identifier
+    public function createIdentifierValue(string $path, $value, ?Relation $relation = null): Identifier
     {
         return new Identifier($this->spec, $this->translator, $path, $value, $relation);
     }

src/Values/Identifier.php

@@ -73,7 +73,7 @@ public function __construct(
         Translator $translator,
         string $path,
         $value,
-        Relation $relation = null
+        ?Relation $relation = null
     ) {
         $this->spec = $spec;
         $this->translator = $translator;