[11.x] chore: update to PHPStan Level 1 (#51956)

* chore: update to phpstan level 1

* chore: update facades to use @mixin

* fix: HasAttributes::relationsToArray isset logic

Author: calebdw

phpstan.src.neon.dist

@@ -1,9 +1,10 @@
 parameters:
-    level: 0
+    level: 1
     paths:
         - src
     excludePaths:
         - src/Illuminate/Testing/ParallelRunner.php
+        - src/*/views/*
     ignoreErrors:
         - "#\\(void\\) is used#"
         - "#Access to an undefined property#"

src/Illuminate/Auth/Access/Gate.php

@@ -575,7 +575,7 @@ protected function callBeforeCallbacks($user, $ability, array $arguments)
      * @param  \Illuminate\Contracts\Auth\Authenticatable  $user
      * @param  string  $ability
      * @param  array  $arguments
-     * @param  bool  $result
+     * @param  bool|null  $result
      * @return bool|null
      */
     protected function callAfterCallbacks($user, $ability, array $arguments, $result)

src/Illuminate/Bus/PendingBatch.php

@@ -358,9 +358,7 @@ protected function dispatchExistingBatch($batch)
         try {
             $batch = $batch->add($this->jobs);
         } catch (Throwable $e) {
-            if (isset($batch)) {
-                $batch->delete();
-            }
+            $batch->delete();
 
             throw $e;
         }

src/Illuminate/Cache/RetrievesMultipleKeys.php

@@ -21,6 +21,7 @@ public function many(array $keys)
         })->all();
 
         foreach ($keys as $key => $default) {
+            /** @phpstan-ignore arguments.count (some clients don't accept a default) */
             $return[$key] = $this->get($key, $default);
         }
 

src/Illuminate/Collections/Collection.php

@@ -604,7 +604,7 @@ public function hasAny($key)
     /**
      * Concatenate values of a given key as a string.
      *
-     * @param  callable|string  $value
+     * @param  callable|string|null  $value
      * @param  string|null  $glue
      * @return string
      */

src/Illuminate/Database/Connectors/ConnectionFactory.php

@@ -188,7 +188,9 @@ protected function createPdoResolverWithHosts(array $config)
                 }
             }
 
-            throw $e;
+            if (isset($e)) {
+                throw $e;
+            }
         };
     }
 

src/Illuminate/Database/Connectors/MySqlConnector.php

@@ -77,11 +77,9 @@ protected function getSocketDsn(array $config)
      */
     protected function getHostDsn(array $config)
     {
-        extract($config, EXTR_SKIP);
-
-        return isset($port)
-                    ? "mysql:host={$host};port={$port};dbname={$database}"
-                    : "mysql:host={$host};dbname={$database}";
+        return isset($config['port'])
+                    ? "mysql:host={$config['host']};port={$config['port']};dbname={$config['database']}"
+                    : "mysql:host={$config['host']};dbname={$config['database']}";
     }
 
     /**

src/Illuminate/Database/Connectors/PostgresConnector.php

@@ -127,7 +127,7 @@ protected function getDsn(array $config)
         // Sometimes - users may need to connect to a database that has a different
         // name than the database used for "information_schema" queries. This is
         // typically the case if using "pgbouncer" type software when pooling.
-        $database = $connect_via_database ?? $database;
+        $database = $connect_via_database ?? $database ?? null;
         $port = $connect_via_port ?? $port ?? null;
 
         $dsn = "pgsql:{$host}dbname='{$database}'";

src/Illuminate/Database/Console/DatabaseInspectionCommand.php

@@ -58,7 +58,7 @@ protected function getConnectionCount(ConnectionInterface $connection)
     /**
      * Get the connection configuration details for the given connection.
      *
-     * @param  string  $database
+     * @param  string|null  $database
      * @return array
      */
     protected function getConfigFromDatabase($database)

src/Illuminate/Database/Eloquent/Attributes/ObservedBy.php

@@ -13,7 +13,7 @@ class ObservedBy
      * @param  array|string  $classes
      * @return void
      */
-    public function __construct(array|string $classes)
+    public function __construct(public array|string $classes)
     {
     }
 }