Replace MD5 with xxh128 in File::hasSameHash() (#54690)

vlakoff · web-flow · commit bf58d21ecca5 · 2025-02-19T14:17:00.000-06:00
Drop-in replacement. Much faster than MD5, and avoids its security issues.
diff --git a/src/Illuminate/Filesystem/Filesystem.php b/src/Illuminate/Filesystem/Filesystem.php
@@ -547,9 +547,9 @@ public function isWritable($path)
      */
     public function hasSameHash($firstFile, $secondFile)
     {
-        $hash = @md5_file($firstFile);
+        $hash = @hash_file('xxh128', $firstFile);
 
-        return $hash && hash_equals($hash, (string) @md5_file($secondFile));
+        return $hash && hash_equals($hash, (string) @hash_file('xxh128', $secondFile));
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -547,9 +547,9 @@ public function isWritable($path)`
`547`	`547`	`*/`
`548`	`548`	`public function hasSameHash($firstFile, $secondFile)`
`549`	`549`	`{`
`550`		`- $hash = @md5_file($firstFile);`
	`550`	`+ $hash = @hash_file('xxh128', $firstFile);`
`551`	`551`
`552`		`- return $hash && hash_equals($hash, (string) @md5_file($secondFile));`
	`552`	`+ return $hash && hash_equals($hash, (string) @hash_file('xxh128', $secondFile));`
`553`	`553`	`}`
`554`	`554`
`555`	`555`	`/**`