From 0e4c1467f2cac9e81ee130e9a33869a684aac7f9 Mon Sep 17 00:00:00 2001 From: Mior Muhammad Zaki Date: Wed, 13 Nov 2024 11:50:59 +0800 Subject: [PATCH 1/4] [4.x] Supports PHP 8.4 --- .github/workflows/tests.yml | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 924163e..8138e07 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -16,17 +16,20 @@ jobs: strategy: fail-fast: true matrix: - php: ['8.0', 8.1, 8.2, 8.3] - laravel: [9, 10, 11] - exclude: + php: [8.1, 8.2, 8.3, 8.4] + laravel: [10, 11] + include: + - php: 8.2 + laravel: 9 + - php: 8.1 + laravel: 9 - php: '8.0' + laravel: 9 + exclude: + - php: 8.4 laravel: 10 - - php: '8.0' - laravel: 11 - - php: '8.1' + - php: 8.1 laravel: 11 - - php: 8.3 - laravel: 9 name: PHP ${{ matrix.php }} - Laravel ${{ matrix.laravel }} @@ -43,10 +46,15 @@ jobs: tools: composer:v2 coverage: none + - name: Install dependencies run: | - composer require "illuminate/contracts=^${{ matrix.laravel }}" --dev --no-update - composer update --prefer-dist --no-interaction --no-progress + composer update --prefer-dist --no-interaction --no-progress --with="illuminate/support=^${{ matrix.laravel }}" + - name: Execute tests (display deprecations) + run: vendor/bin/phpunit --display-deprecations + if: matrix.laravel >= 10 + - name: Execute tests run: vendor/bin/phpunit + if: matrix.laravel < 10 From e8843965f3a31eb993a7e7d60e30864fe9b5450d Mon Sep 17 00:00:00 2001 From: Mior Muhammad Zaki Date: Wed, 13 Nov 2024 11:51:27 +0800 Subject: [PATCH 2/4] wip --- .github/workflows/tests.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 8138e07..7f498ac 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -46,7 +46,6 @@ jobs: tools: composer:v2 coverage: none - - name: Install dependencies run: | composer update --prefer-dist --no-interaction --no-progress --with="illuminate/support=^${{ matrix.laravel }}" From aa6b9a9f1e0af58d33a8653835beac4e699a8387 Mon Sep 17 00:00:00 2001 From: Mior Muhammad Zaki Date: Wed, 13 Nov 2024 12:18:17 +0800 Subject: [PATCH 3/4] wip --- .github/workflows/tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 7f498ac..41d5f3a 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -51,7 +51,7 @@ jobs: composer update --prefer-dist --no-interaction --no-progress --with="illuminate/support=^${{ matrix.laravel }}" - name: Execute tests (display deprecations) - run: vendor/bin/phpunit --display-deprecations + run: vendor/bin/phpunit --display-deprecations --fail-on-deprecation if: matrix.laravel >= 10 - name: Execute tests From 7def1c97e36fa4af935177f158f69c6b0474ae4b Mon Sep 17 00:00:00 2001 From: Mior Muhammad Zaki Date: Thu, 14 Nov 2024 14:40:59 +0800 Subject: [PATCH 4/4] Update tests.yml --- .github/workflows/tests.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index 41d5f3a..d0842a9 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -50,10 +50,5 @@ jobs: run: | composer update --prefer-dist --no-interaction --no-progress --with="illuminate/support=^${{ matrix.laravel }}" - - name: Execute tests (display deprecations) - run: vendor/bin/phpunit --display-deprecations --fail-on-deprecation - if: matrix.laravel >= 10 - - name: Execute tests - run: vendor/bin/phpunit - if: matrix.laravel < 10 + run: vendor/bin/phpunit ${{ matrix.laravel >= 10 && '--display-deprecations --fail-on-deprecation' || '' }}