Merge pull request #399 from N1ebieski/Fix-Translation-detection-breaks-when-there-are-blank-lines-in-a-JSON-file-#42

Fix Translation detection breaks when there are blank lines in a JSON file

Author: joetannenbaum

php-templates/translations.php

@@ -133,7 +133,7 @@ protected function linesFromJsonFile($file)
             array_keys($json),
         );
         $result = [];
-        $searchRange = 2;
+        $searchRange = 5;
 
         foreach ($encoded as $index => $keys) {
             // Pretty likely to be on the line that is the index, go happy path first
@@ -142,7 +142,7 @@ protected function linesFromJsonFile($file)
                 continue;
             }
 
-            // Search around the index, like to be within 2 lines
+            // Search around the index, likely to be within $searchRange lines
             $start = max(0, $index - $searchRange);
             $end = min($index + $searchRange, count($lines) - 1);
             $current = $start;

src/templates/translations.ts

@@ -133,7 +133,7 @@ $translator = new class
             array_keys($json),
         );
         $result = [];
-        $searchRange = 2;
+        $searchRange = 5;
 
         foreach ($encoded as $index => $keys) {
             // Pretty likely to be on the line that is the index, go happy path first
@@ -142,7 +142,7 @@ $translator = new class
                 continue;
             }
 
-            // Search around the index, like to be within 2 lines
+            // Search around the index, likely to be within $searchRange lines
             $start = max(0, $index - $searchRange);
             $end = min($index + $searchRange, count($lines) - 1);
             $current = $start;