wip

Author: joetannenbaum

.github/workflows/build-release-binaries.yml

@@ -35,10 +35,6 @@ jobs:
           php-version: "8.2"
           extensions: bcmath,calendar,ctype,curl,dba,dom,exif,fileinfo,filter,iconv,mbstring,openssl,pcntl,pdo_mysql,pdo_sqlite,pdo,phar,posix,readline,session,simplexml,sockets,sodium,sqlite3,tokenizer,xml,xmlreader,xmlwriter,zip,zlib
 
-      - name: Get the version
-        id: get_version
-        run: echo "VERSION=${GITHUB_REF#refs/tags/}" >> $GITHUB_ENV
-
       - name: Install dependencies
         run: |
           composer install --prefer-dist --no-progress --no-dev --quiet
@@ -53,7 +49,7 @@ jobs:
       - name: Build Binary
         run: |
           echo "" > .env
-          php php-parser app:build --build-version=${{ env.VERSION }}
+          php php-parser app:build --build-version=${{ github.ref_name }}
 
       - name: Download PHP
         run: |
@@ -64,20 +60,20 @@ jobs:
 
       - name: SPC Combine
         run: |
-          ./spc micro:combine builds/php-parser -O bin/php-parser-${{ env.VERSION }}-${{ matrix.arch }}
+          ./spc micro:combine builds/php-parser -O bin/php-parser-${{ github.ref_name }}-${{ matrix.arch }}
 
       - name: Upload binary as artifact
         uses: actions/upload-artifact@v4
         with:
-          name: php-parser-${{ env.VERSION }}-${{ matrix.arch }}
-          path: bin/php-parser-${{ env.VERSION }}-${{ matrix.arch }}
+          name: php-parser-${{ github.ref_name }}-${{ matrix.arch }}
+          path: bin/php-parser-${{ github.ref_name }}-${{ matrix.arch }}
 
       - name: Create Release
         uses: softprops/action-gh-release@v1
         if: startsWith(github.ref, 'refs/tags/')
         with:
           files: |
-            bin/php-parser-${{ env.VERSION }}-${{ matrix.arch }}
+            bin/php-parser-${{ github.ref_name }}-${{ matrix.arch }}
           fail_on_unmatched_files: true
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/build-windows-release-binary.yml

@@ -52,14 +52,14 @@ jobs:
         uses: actions/upload-artifact@v4
         with:
           name: php-parser-${{ github.ref_name }}-x64-win32
-          path: bin\php-parser-${{ github.ref_name }}-x64-win32
+          path: bin/php-parser-${{ github.ref_name }}-x64-win32.exe
 
       - name: Create Release
         uses: softprops/action-gh-release@v1
         if: startsWith(github.ref, 'refs/tags/')
         with:
           files: |
-            bin\php-parser-${{ github.ref_name }}-x64-win32
+            bin/php-parser-${{ github.ref_name }}-x64-win32.exe
           fail_on_unmatched_files: true
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}