Fix forum overview sort order (#800)

* Make last_activity_at fillable

* Remove command

* Prevent replies to old threads

* Apply fixes from StyleCI

Co-authored-by: StyleCI Bot <[email protected]>

Author: joedixon

Diff for: app/Console/Commands/UpdateThreadActivity.php

@@ -20,7 +20,15 @@ public function rules()
 
     public function replyAble(): ReplyAble
     {
-        return $this->findReplyAble($this->get('replyable_id'), $this->get('replyable_type'));
+        $replyable = $this->findReplyAble($this->get('replyable_id'), $this->get('replyable_type'));
+
+        abort_if(
+            $replyable->isConversationOld(),
+            403,
+            'Last activity is too old',
+        );
+
+        return $replyable;
     }
 
     private function findReplyAble(int $id, string $type): ReplyAble

Diff for: app/Http/Requests/CreateReplyRequest.php

@@ -55,6 +55,7 @@ final class Thread extends Model implements Feedable, ReplyAble, SubscriptionAbl
         'body',
         'slug',
         'subject',
+        'last_activity_at',
     ];
 
     /**

Diff for: app/Models/Thread.php

@@ -228,3 +228,15 @@
     $this->visit("/forum/tags/{$tag->slug}?filter=something-invalid")
         ->see('href="http://localhost/forum/tags/'.$tag->slug.'?filter=recent" aria-current="page"');
 });
+
+test('thread activity is set when a new thread is created', function () {
+    $this->login();
+
+    $this->post('/forum/create-thread', [
+        'subject' => 'How to work with Eloquent?',
+        'body' => 'This text explains how to work with Eloquent.',
+        'tags' => [],
+    ]);
+
+    $this->assertNotNull(Thread::latest('id')->first()->last_activity_at);
+});

Diff for: tests/Feature/ForumTest.php

@@ -65,7 +65,7 @@
         ->assertForbidden();
 });
 
-test('users cannot reply to a thread if the last reply is older than six months', function () {
+test('users cannot see the option to reply if the latest activity is older than six months', function () {
     $thread = Thread::factory()->old()->create();
 
     $this->login();
@@ -77,6 +77,18 @@
         );
 });
 
+test('users cannot reply to a thread if the latest activity is older than six months', function () {
+    $thread = Thread::factory()->old()->create();
+
+    $this->login();
+
+    $this->post('/replies', [
+        'body' => 'The first reply',
+        'replyable_id' => $thread->id,
+        'replyable_type' => Thread::TABLE,
+    ])->assertForbidden();
+});
+
 test('verified users can see the reply input', function () {
     $thread = Thread::factory()->create();