Skip to content

Commit 570754c

Browse files
committed
Breaking more retain cycles. PBGitCommits are finally released correctly.
1 parent 64bf8d1 commit 570754c

File tree

4 files changed

+10
-2
lines changed

4 files changed

+10
-2
lines changed

GitXTextFieldCell.h

+3-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@
1111

1212

1313
@interface GitXTextFieldCell : NSTextFieldCell {
14-
IBOutlet id<PBRefContextDelegate> contextMenuDelegate;
14+
__unsafe_unretained id<PBRefContextDelegate> contextMenuDelegate;
1515
}
1616

17+
@property(nonatomic, unsafe_unretained) IBOutlet id<PBRefContextDelegate> contextMenuDelegate;
18+
1719
@end

GitXTextFieldCell.m

+2
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@
1313

1414
@implementation GitXTextFieldCell
1515

16+
@synthesize contextMenuDelegate;
17+
1618
- (NSColor *)highlightColorWithFrame:(NSRect)cellFrame inView:(NSView *)controlView
1719
{
1820
// disables the cell's selection highlight

PBWebStashController.h

+3-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,9 @@
1010
@class PBStashContentController;
1111

1212
@interface PBWebStashController : PBWebCommitController {
13-
IBOutlet PBStashContentController *stashController;
13+
__unsafe_unretained PBStashContentController *stashController;
1414
}
1515

16+
@property(nonatomic, unsafe_unretained) IBOutlet PBStashContentController *stashController;
17+
1618
@end

PBWebStashController.m

+2
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99

1010
@implementation PBWebStashController
1111

12+
@synthesize stashController;
13+
1214
- (void)selectCommit:(NSString *)sha
1315
{
1416
[[stashController superController] selectCommitForSha:sha];

0 commit comments

Comments
 (0)