Skip to content

Commit 63daf60

Browse files
committed
Only bother mocking Date.now
1 parent 7d77879 commit 63daf60

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

packages/shared/akamai-edgeworker-sdk/__tests__/featureStore/cacheableStore.test.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,21 +66,23 @@ describe('given a mock edge provider with test data', () => {
6666
});
6767

6868
it('caches expires after duration', async () => {
69+
jest.spyOn(Date, 'now').mockImplementation(() => 0);
6970
const cacheProvider = new CacheableStoreProvider(mockEdgeProvider, 'rootKey', 50);
7071
await cacheProvider.get('rootKey');
7172
await cacheProvider.get('rootKey');
7273
expect(mockGet).toHaveBeenCalledTimes(1);
7374

74-
await jest.advanceTimersByTimeAsync(20);
75+
jest.spyOn(Date, 'now').mockImplementation(() => 20);
7576
await cacheProvider.get('rootKey');
7677
expect(mockGet).toHaveBeenCalledTimes(1);
7778

78-
await jest.advanceTimersByTimeAsync(30);
79+
jest.spyOn(Date, 'now').mockImplementation(() => 50);
7980
await cacheProvider.get('rootKey');
8081
expect(mockGet).toHaveBeenCalledTimes(2);
8182
});
8283

8384
it('prefetch respects cache TTL', async () => {
85+
jest.spyOn(Date, 'now').mockImplementation(() => 0);
8486
const cacheProvider = new CacheableStoreProvider(mockEdgeProvider, 'rootKey', 50);
8587
await cacheProvider.get('rootKey');
8688
await cacheProvider.get('rootKey');
@@ -90,7 +92,7 @@ describe('given a mock edge provider with test data', () => {
9092
await cacheProvider.get('rootKey');
9193
expect(mockGet).toHaveBeenCalledTimes(1);
9294

93-
await jest.advanceTimersByTimeAsync(50);
95+
jest.spyOn(Date, 'now').mockImplementation(() => 50);
9496
await cacheProvider.prefetchPayloadFromOriginStore();
9597
await cacheProvider.get('rootKey');
9698
expect(mockGet).toHaveBeenCalledTimes(2);

packages/shared/akamai-edgeworker-sdk/src/featureStore/cacheableStoreProvider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export default class CacheableStoreProvider implements EdgeProvider {
7070
private _isCacheValid(): boolean {
7171
// If we don't have a cache, or we don't know how old the cache is, we have
7272
// to consider it is invalid.
73-
if (!this.cache || !this.cachedAt) {
73+
if (!this.cache || this.cachedAt === undefined) {
7474
return false;
7575
}
7676

0 commit comments

Comments
 (0)