feat: Always inline contexts for feature events (#351)

launchdarkly · Mar 13, 2024 · e721f3b · e721f3b
1 parent 0b131c0
commit e721f3b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 19 deletions.
diff --git a/contract-tests/index.js b/contract-tests/index.js
@@ -31,7 +31,8 @@ app.get('/', (req, res) => {
       'migrations',
       'event-sampling',
       'strongly-typed',
-      'polling-gzip'
+      'polling-gzip',
+      'inline-context',
     ],
   });
 });

diff --git a/packages/shared/common/__tests__/internal/events/EventProcessor.test.ts b/packages/shared/common/__tests__/internal/events/EventProcessor.test.ts
@@ -73,19 +73,11 @@ function makeFeatureEvent(
     variation,
     value,
     default: def,
-    ...(debug
-      ? {
-          context: {
-            key: 'userKey',
-            name: 'Red',
-            kind: 'user',
-          },
-        }
-      : {
-          contextKeys: {
-            user: 'userKey',
-          },
-        }),
+    context: {
+      key: 'userKey',
+      name: 'Red',
+      kind: 'user',
+    },
   };
 }
 

diff --git a/packages/shared/common/src/internal/events/EventProcessor.ts b/packages/shared/common/src/internal/events/EventProcessor.ts
@@ -270,6 +270,7 @@ export default class EventProcessor implements LDEventProcessor {
         const out: FeatureOutputEvent = {
           kind: debug ? 'debug' : 'feature',
           creationDate: event.creationDate,
+          context: this.contextFilter.filter(event.context),
           key: event.key,
           value: event.value,
           default: event.default,
@@ -289,11 +290,6 @@ export default class EventProcessor implements LDEventProcessor {
         if (event.reason) {
           out.reason = event.reason;
         }
-        if (debug) {
-          out.context = this.contextFilter.filter(event.context);
-        } else {
-          out.contextKeys = event.context.kindsAndKeys;
-        }
         return out;
       }
       case 'index': // Intentional fallthrough.