Skip to content

Commit fa247b2

Browse files
authored
feat: Make timeout optional in LDIdentifyOptions. (#552)
In the strictest sense this would be a breaking change, but in the practical I think it is not likely to be. The way this would be breaking is if someone was using this for something other than just passing to the identify function. This would be somewhat unusual. Example: ``` interface MyOptions: { timeout: number; } let myOptions: MyOptions = someLdIdentifyOptions; ``` For standard usage this will not be breaking. I am tagging this as a feat instead of a fix to prevent any breakage for someone floating patches and also doing unusual things with the type.
1 parent 64ab88d commit fa247b2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

packages/shared/sdk-client/src/api/LDIdentifyOptions.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export interface LDIdentifyOptions {
77
*
88
* Defaults to 5 seconds.
99
*/
10-
timeout: number;
10+
timeout?: number;
1111

1212
/**
1313
* When true indicates that the SDK will attempt to wait for values from

0 commit comments

Comments
 (0)