Skip to content

Commit 352feee

Browse files
authored
Merge pull request #24 from EkkoG/master
use swift 5 compitable version of LayoutKit
2 parents f0077d0 + d3edef8 commit 352feee

File tree

3 files changed

+54
-55
lines changed

3 files changed

+54
-55
lines changed

LayoutFrameworkBenchmark/Benchmarks/BenchmarkViewController.swift

+7-5
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class BenchmarkViewController: UITableViewController {
2929
return CollectionViewControllerFeedItemFlexLayoutView(data: data)
3030
}),
3131

32-
ViewControllerData(title: "LayoutKit 10.0", factoryBlock: { viewCount in
32+
ViewControllerData(title: "LayoutKit 10.1", factoryBlock: { viewCount in
3333
let data = FeedItemData.generate(count: viewCount)
3434
return CollectionViewControllerFeedItemLayoutKitView(data: data)
3535
}),
@@ -39,7 +39,7 @@ class BenchmarkViewController: UITableViewController {
3939
return CollectionViewControllerFeedItemManualView(data: data)
4040
}),
4141

42-
ViewControllerData(title: "NKFrameLayoutKit 2.4", factoryBlock: { viewCount in
42+
ViewControllerData(title: "NKFrameLayoutKit 2.5", factoryBlock: { viewCount in
4343
let data = FeedItemData.generate(count: viewCount)
4444
return CollectionViewControllerFeedItemNKFrameLayoutKitView(data: data)
4545
}),
@@ -49,12 +49,12 @@ class BenchmarkViewController: UITableViewController {
4949
return CollectionViewControllerFeedItemNotAutoLayoutView(data: data)
5050
}),
5151

52-
ViewControllerData(title: "PinLayout 1.9", factoryBlock: { viewCount in
52+
ViewControllerData(title: "PinLayout 1.10", factoryBlock: { viewCount in
5353
let data = FeedItemData.generate(count: viewCount)
5454
return CollectionViewControllerFeedItemPinLayoutView(data: data)
5555
}),
5656

57-
ViewControllerData(title: "Texture", factoryBlock: { viewCount in
57+
ViewControllerData(title: "Texture 3.1", factoryBlock: { viewCount in
5858
let data = FeedItemData.generate(count: viewCount)
5959
return TextureCollectionViewController(data: data)
6060
}),
@@ -134,7 +134,9 @@ class BenchmarkViewController: UITableViewController {
134134
private func printResults(name: String, results: [Result]) {
135135
var resultsString = "\(name)\t"
136136
results.forEach { (result) in
137-
resultsString += "\(result.secondsPerOperation)\t"
137+
let a = "\(result.secondsPerOperation)"
138+
resultsString += String(a.prefix(6))
139+
resultsString += ","
138140
}
139141
print(resultsString)
140142
}

Podfile

+1-12
Original file line numberDiff line numberDiff line change
@@ -10,22 +10,11 @@ inhibit_all_warnings!
1010

1111
target 'LayoutFrameworkBenchmark' do
1212
pod 'FlexLayout'
13-
pod 'LayoutKit'
13+
pod 'LayoutKit', :git => 'https://github.com/LinkedInAttic/LayoutKit.git'
1414
pod 'NotAutoLayout'
1515
pod 'NKFrameLayoutKit'
1616
pod 'PinLayout'
1717
pod 'Texture'
1818

1919
pod 'Reveal-SDK'
2020
end
21-
22-
23-
post_install do |installer|
24-
installer.pods_project.targets.each do |target|
25-
if ['LayoutKit'].include? target.name
26-
target.build_configurations.each do |config|
27-
config.build_settings['SWIFT_VERSION'] = '4.1'
28-
end
29-
end
30-
end
31-
end

Podfile.lock

+46-38
Original file line numberDiff line numberDiff line change
@@ -1,49 +1,49 @@
11
PODS:
2-
- FlexLayout (1.3.17)
2+
- FlexLayout (1.3.23)
33
- LayoutKit (10.1.0)
44
- NKFrameLayoutKit (2.5)
55
- NotAutoLayout (3.2.0)
6-
- PINCache (3.0.1-beta.8):
7-
- PINCache/Arc-exception-safe (= 3.0.1-beta.8)
8-
- PINCache/Core (= 3.0.1-beta.8)
9-
- PINCache/Arc-exception-safe (3.0.1-beta.8):
6+
- PINCache (3.0.3):
7+
- PINCache/Arc-exception-safe (= 3.0.3)
8+
- PINCache/Core (= 3.0.3)
9+
- PINCache/Arc-exception-safe (3.0.3):
1010
- PINCache/Core
11-
- PINCache/Core (3.0.1-beta.8):
12-
- PINOperation (~> 1.1.1)
13-
- PinLayout (1.8.13)
14-
- PINOperation (1.1.2)
15-
- PINRemoteImage/Core (3.0.0):
11+
- PINCache/Core (3.0.3):
12+
- PINOperation (~> 1.2.1)
13+
- PinLayout (1.10.0)
14+
- PINOperation (1.2.1)
15+
- PINRemoteImage/Core (3.0.3):
1616
- PINOperation
17-
- PINRemoteImage/iOS (3.0.0):
17+
- PINRemoteImage/iOS (3.0.3):
1818
- PINRemoteImage/Core
19-
- PINRemoteImage/PINCache (3.0.0):
20-
- PINCache (= 3.0.1-beta.8)
19+
- PINRemoteImage/PINCache (3.0.3):
20+
- PINCache (~> 3.0.3)
2121
- PINRemoteImage/Core
22-
- Reveal-SDK (26)
23-
- Texture (3.0.0):
24-
- Texture/AssetsLibrary (= 3.0.0)
25-
- Texture/Core (= 3.0.0)
26-
- Texture/MapKit (= 3.0.0)
27-
- Texture/Photos (= 3.0.0)
28-
- Texture/PINRemoteImage (= 3.0.0)
29-
- Texture/Video (= 3.0.0)
30-
- Texture/AssetsLibrary (3.0.0):
22+
- Reveal-SDK (33)
23+
- Texture (3.1.0):
24+
- Texture/AssetsLibrary (= 3.1.0)
25+
- Texture/Core (= 3.1.0)
26+
- Texture/MapKit (= 3.1.0)
27+
- Texture/Photos (= 3.1.0)
28+
- Texture/PINRemoteImage (= 3.1.0)
29+
- Texture/Video (= 3.1.0)
30+
- Texture/AssetsLibrary (3.1.0):
3131
- Texture/Core
32-
- Texture/Core (3.0.0)
33-
- Texture/MapKit (3.0.0):
32+
- Texture/Core (3.1.0)
33+
- Texture/MapKit (3.1.0):
3434
- Texture/Core
35-
- Texture/Photos (3.0.0):
35+
- Texture/Photos (3.1.0):
3636
- Texture/Core
37-
- Texture/PINRemoteImage (3.0.0):
37+
- Texture/PINRemoteImage (3.1.0):
3838
- PINRemoteImage/iOS (~> 3.0.0)
3939
- PINRemoteImage/PINCache
4040
- Texture/Core
41-
- Texture/Video (3.0.0):
41+
- Texture/Video (3.1.0):
4242
- Texture/Core
4343

4444
DEPENDENCIES:
4545
- FlexLayout
46-
- LayoutKit
46+
- LayoutKit (from `https://github.com/LinkedInAttic/LayoutKit.git`)
4747
- NKFrameLayoutKit
4848
- NotAutoLayout
4949
- PinLayout
@@ -53,7 +53,6 @@ DEPENDENCIES:
5353
SPEC REPOS:
5454
trunk:
5555
- FlexLayout
56-
- LayoutKit
5756
- NKFrameLayoutKit
5857
- NotAutoLayout
5958
- PINCache
@@ -63,18 +62,27 @@ SPEC REPOS:
6362
- Reveal-SDK
6463
- Texture
6564

65+
EXTERNAL SOURCES:
66+
LayoutKit:
67+
:git: https://github.com/LinkedInAttic/LayoutKit.git
68+
69+
CHECKOUT OPTIONS:
70+
LayoutKit:
71+
:commit: 1f1b067b6b11a0779ea6b6ccd976585a1d7bb79b
72+
:git: https://github.com/LinkedInAttic/LayoutKit.git
73+
6674
SPEC CHECKSUMS:
67-
FlexLayout: 257b6763526bc957d2abc2b77a05760b86ca0e21
75+
FlexLayout: 5b44c0538e7eaa2110e3160dfdfb74611676fb91
6876
LayoutKit: 66478bb3af5ce4519a056d9465bc4c7585d2350b
6977
NKFrameLayoutKit: 8485fd4fb04c2c99e38e4dfd4b65a99ce10689b9
7078
NotAutoLayout: 4723ad82a21a7c6c60c823fff7f7c29467811b92
71-
PINCache: 534fd41d358d828dfdf227a0d327f3673a65e20b
72-
PinLayout: e41a50260a76508b7a7fcee8955c76639adc69bc
73-
PINOperation: 24b774353ca248fcf87d67b2d61eef42087c125a
74-
PINRemoteImage: e2b89e19fb6e77ffc099f9d9f3b3fe1745e3f9f9
75-
Reveal-SDK: 5f94f14aff3d5f2a49f246edcd266fa4472679e9
76-
Texture: 2f109e937850d94d1d07232041c9c7313ccddb81
79+
PINCache: 7a8fc1a691173d21dbddbf86cd515de6efa55086
80+
PinLayout: e50e9a748b632905fca6e67043ea4b05d6c92186
81+
PINOperation: 00c935935f1e8cf0d1e2d6b542e75b88fc3e5e20
82+
PINRemoteImage: f1295b29f8c5e640e25335a1b2bd9d805171bd01
83+
Reveal-SDK: effba1c940b8337195563c425a6b5862ec875caa
84+
Texture: 2e8ab2519452515f7f5a520f5a8f7e0a413abfa3
7785

78-
PODFILE CHECKSUM: e88cf8183859e80454f97e5a3e30c34f9c220e27
86+
PODFILE CHECKSUM: dca07728abcbc052a30cef591b8cd349297c894b
7987

80-
COCOAPODS: 1.9.3
88+
COCOAPODS: 1.11.2

0 commit comments

Comments
 (0)