Skip to content

Commit 64b24df

Browse files
committed
feature: layout cells with Texture
1 parent a95dd17 commit 64b24df

File tree

5 files changed

+185
-189
lines changed

5 files changed

+185
-189
lines changed

LayoutFrameworkBenchmark.xcodeproj/project.pbxproj

+4
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
639E5A2020DF62D700C6BCEA /* NKFrameLayoutKitView.swift in Sources */ = {isa = PBXBuildFile; fileRef = 639E5A1F20DF62D700C6BCEA /* NKFrameLayoutKitView.swift */; };
2828
BF3DC69820B560A400536177 /* FeedItemNotAutoLayoutView.swift in Sources */ = {isa = PBXBuildFile; fileRef = BF3DC69720B560A400536177 /* FeedItemNotAutoLayoutView.swift */; };
2929
E4A8A14124FE99B1009D872B /* FeedItemTextureView.swift in Sources */ = {isa = PBXBuildFile; fileRef = E4A8A14024FE982E009D872B /* FeedItemTextureView.swift */; };
30+
E4A8A24F24FEDD14009D872B /* TextureCollectionViewController.swift in Sources */ = {isa = PBXBuildFile; fileRef = E4A8A24E24FEDD14009D872B /* TextureCollectionViewController.swift */; };
3031
/* End PBXBuildFile section */
3132

3233
/* Begin PBXFileReference section */
@@ -54,6 +55,7 @@
5455
73BD901DE3512A23A7603899 /* Pods-LayoutFrameworkBenchmark.debug.xcconfig */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = text.xcconfig; name = "Pods-LayoutFrameworkBenchmark.debug.xcconfig"; path = "Pods/Target Support Files/Pods-LayoutFrameworkBenchmark/Pods-LayoutFrameworkBenchmark.debug.xcconfig"; sourceTree = "<group>"; };
5556
BF3DC69720B560A400536177 /* FeedItemNotAutoLayoutView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FeedItemNotAutoLayoutView.swift; sourceTree = "<group>"; };
5657
E4A8A14024FE982E009D872B /* FeedItemTextureView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = FeedItemTextureView.swift; sourceTree = "<group>"; };
58+
E4A8A24E24FEDD14009D872B /* TextureCollectionViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TextureCollectionViewController.swift; sourceTree = "<group>"; };
5759
/* End PBXFileReference section */
5860

5961
/* Begin PBXFrameworksBuildPhase section */
@@ -215,6 +217,7 @@
215217
isa = PBXGroup;
216218
children = (
217219
E4A8A14024FE982E009D872B /* FeedItemTextureView.swift */,
220+
E4A8A24E24FEDD14009D872B /* TextureCollectionViewController.swift */,
218221
);
219222
name = Texture;
220223
sourceTree = "<group>";
@@ -350,6 +353,7 @@
350353
isa = PBXSourcesBuildPhase;
351354
buildActionMask = 2147483647;
352355
files = (
356+
E4A8A24F24FEDD14009D872B /* TextureCollectionViewController.swift in Sources */,
353357
2401BCA11F4F044000788998 /* FeedItemUIStackView.swift in Sources */,
354358
2401BC8B1F4F018C00788998 /* Stopwatch.swift in Sources */,
355359
2401BC8F1F4F01D600788998 /* FeedItemLayoutKitView.swift in Sources */,

LayoutFrameworkBenchmark/Benchmarks/BenchmarkViewController.swift

+5-5
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,6 @@ class BenchmarkViewController: UITableViewController {
1818
//
1919
// Ordered alphabetically
2020
//
21-
22-
ViewControllerData(title: "Texture", factoryBlock: { viewCount in
23-
let data = FeedItemData.generate(count: viewCount)
24-
return CollectionViewControllerFeedItemTextureView(data: data)
25-
}),
2621

2722
ViewControllerData(title: "Auto Layout", factoryBlock: { viewCount in
2823
let data = FeedItemData.generate(count: viewCount)
@@ -59,6 +54,11 @@ class BenchmarkViewController: UITableViewController {
5954
return CollectionViewControllerFeedItemPinLayoutView(data: data)
6055
}),
6156

57+
ViewControllerData(title: "Texture", factoryBlock: { viewCount in
58+
let data = FeedItemData.generate(count: viewCount)
59+
return TextureCollectionViewController(data: data)
60+
}),
61+
6262
ViewControllerData(title: "UIStackView", factoryBlock: { viewCount in
6363
if #available(iOS 9.0, *) {
6464
let data = FeedItemData.generate(count: viewCount)

LayoutFrameworkBenchmark/Benchmarks/CollectionViewController.swift

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ import UIKit
2222
@available(iOS 9, *)
2323
class CollectionViewControllerFeedItemUIStackView: CollectionViewController<FeedItemUIStackView> {}
2424

25-
class CollectionViewControllerFeedItemTextureView: CollectionViewController<FeedItemTextureView> {}
2625
class CollectionViewControllerFeedItemAutoLayoutView: CollectionViewController<FeedItemAutoLayoutView> {}
2726
class CollectionViewControllerFeedItemLayoutKitView: CollectionViewController<FeedItemLayoutKitView> {}
2827
class CollectionViewControllerFeedItemManualView: CollectionViewController<FeedItemManualView> {}

0 commit comments

Comments
 (0)