Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Docs: Must Have Package Loaded #95

Open
andreweatherman opened this issue Feb 2, 2023 · 1 comment
Open

Improve Docs: Must Have Package Loaded #95

andreweatherman opened this issue Feb 2, 2023 · 1 comment

Comments

@andreweatherman
Copy link

Turns out that you need to have ncaahoopR loaded in your session for the functions to not return an error. This is because the code does not namespace its own functions (i.e. dict$ESPN_PBP in get_pbp_game). This affects nearly every function in the package. Maybe this can be listed somewhere in the documentation -- to be sure that the package is loaded inside your environment before running it. ncaahoopR::get_pbp_game(...) will not work.

@lbenz730
Copy link
Owner

lbenz730 commented Feb 3, 2023

Thanks let me see if i can just namespace my own functions, if not i'll update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants