Skip to content

Commit 162c039

Browse files
committed
Revert range-based loops change
Windows OpenMP does not support range-based loops
1 parent 4ed6881 commit 162c039

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

.clang-tidy

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ Checks: >
2020
-misc-unused-parameters,
2121
-misc-use-anonymous-namespace,
2222
-modernize-avoid-c-arrays,
23+
-modernize-loop-convert,
2324
-modernize-use-nodiscard,
2425
-modernize-use-trailing-return-type,
2526
-readability-function-cognitive-complexity,

tasks/omp/example/src/ops_omp.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,18 +63,18 @@ bool nesterov_a_test_task_omp::TestOMPTaskParallel::run_impl() {
6363
auto temp_res = res;
6464
if (ops == "+") {
6565
#pragma omp parallel for reduction(+ : temp_res)
66-
for (int i : input_) {
67-
temp_res += i;
66+
for (int i = 0; i < static_cast<int>(input_.size()); i++) {
67+
temp_res += input_[i];
6868
}
6969
} else if (ops == "-") {
7070
#pragma omp parallel for reduction(- : temp_res)
71-
for (int i : input_) {
72-
temp_res -= i;
71+
for (int i = 0; i < static_cast<int>(input_.size()); i++) {
72+
temp_res -= input_[i];
7373
}
7474
} else if (ops == "*") {
7575
#pragma omp parallel for reduction(* : temp_res)
76-
for (int i : input_) {
77-
temp_res *= i;
76+
for (int i = 0; i < static_cast<int>(input_.size()); i++) {
77+
temp_res *= input_[i];
7878
}
7979
}
8080
res = temp_res;

0 commit comments

Comments
 (0)