Add cppcheck (#36)

Nesterov Alexander · Nesterov Alexander · web-flow · commit 417f835b1bd5 · 2020-11-15T04:39:52.000+03:00
* init cppcheck

* update apple cppcheck

Co-authored-by: Nesterov Alexander &lt;nesoldr@mail.ru&gt;
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -12,6 +12,7 @@ jobs:
         sudo add-apt-repository ppa:ubuntu-toolchain-r/test
         sudo apt-get update
         sudo apt-get install g++-9
+        sudo apt-get install cppcheck
         sudo apt-get install mpich libmpich-dev
         sudo apt-get install libomp-9-dev libtbb-dev
         sudo apt-get install texlive*
@@ -40,7 +41,8 @@ jobs:
     - name: Setup environment
       run: |
         sudo add-apt-repository ppa:ubuntu-toolchain-r/test
-        sudo apt-get update 
+        sudo apt-get update
+        sudo apt-get install cppcheck
         sudo apt-get install clang-8 mpich libmpich-dev libomp-9-dev libtbb-dev texlive*
     - name: Update submodules
       run: git submodule update --init --recursive
@@ -69,6 +71,7 @@ jobs:
         brew update-reset
         brew unlink python@3.8
         brew install open-mpi libomp tbb
+        brew install cppcheck
     - name: Update submodules
       run: git submodule update --init --recursive
     - name: Run linter
diff --git a/.travis.yml b/.travis.yml
@@ -7,7 +7,9 @@ matrix:
       addons:
         apt:
           sources: ubuntu-toolchain-r-test
-          packages: g++-5
+          packages:
+            - g++-5
+            - cppcheck
       env: MATRIX_EVAL="CC=gcc-5 && CXX=g++-5"
       before_script:
         - python scripts/lint.py
@@ -17,20 +19,28 @@ matrix:
       addons:
         apt:
           sources: ubuntu-toolchain-r-test
-          packages: g++-8
+          packages:
+            - g++-8
+            - cppcheck
       env: MATRIX_EVAL="CC=gcc-8 && CXX=g++-8
 
     - os: linux
       dist: xenial
       compiler: clang
       addons:
         apt:
-          packages: clang-5.0
+          packages:
+            - clang-5.0
+            - cppcheck
       env: MATRIX_EVAL="CC=clang-5.0 && CXX=clang++-5.0"
 
     - os: linux
       dist: xenial
       compiler: clang
+      addons:
+        apt:
+          packages:
+            - cppcheck
 
     - os: osx
       osx_image: xcode10.1
@@ -46,6 +56,7 @@ install:
 - if [[ $TRAVIS_OS_NAME == 'osx' ]]; then brew update-reset; fi
 - if [[ $TRAVIS_OS_NAME == 'osx' ]]; then brew unlink python@2; fi
 - if [[ $TRAVIS_OS_NAME == 'osx' ]]; then brew install open-mpi libomp tbb; fi
+- if [[ $TRAVIS_OS_NAME == 'osx' ]]; then brew install cppcheck; fi
 
 - if [[ $TRAVIS_OS_NAME == 'linux' ]]; then sudo apt-get install mpich libmpich-dev; fi
 - if [[ $TRAVIS_OS_NAME == 'linux' ]]; then sudo apt-get install libomp-dev libtbb-dev; fi
diff --git a/modules/test_tasks/test_mpi/CMakeLists.txt b/modules/test_tasks/test_mpi/CMakeLists.txt
@@ -31,6 +31,30 @@ if( USE_MPI )
 
     enable_testing()
     add_test(NAME ${ProjectId} COMMAND ${ProjectId})
+
+    if( UNIX )
+        file(GLOB_RECURSE ALL_SOURCE_FILES *.cpp *.h)
+        foreach (SOURCE_FILE ${ALL_SOURCE_FILES})
+            string(FIND ${SOURCE_FILE} ${PROJECT_BINARY_DIR} PROJECT_TRDPARTY_DIR_FOUND)
+            if (NOT ${PROJECT_TRDPARTY_DIR_FOUND} EQUAL -1)
+                list(REMOVE_ITEM ALL_SOURCE_FILES ${SOURCE_FILE})
+            endif ()
+        endforeach ()
+
+        find_program(CPPCHECK cppcheck)
+        add_custom_target(
+                "${ProjectId}_cppcheck" ALL
+                COMMAND ${CPPCHECK}
+                --enable=warning,performance,portability,information,missingInclude
+                --language=c++
+                --std=c++11
+                --error-exitcode=1
+                --template="[{severity}][{id}] {message} {callstack} \(On {file}:{line}\)"
+                --verbose
+                --quiet
+                ${ALL_SOURCE_FILES}
+        )
+    endif( UNIX )
 else( USE_MPI )
     message( STATUS "-- ${ProjectId} - NOT BUILD!"  )
 endif( USE_MPI )
diff --git a/modules/test_tasks/test_mpi/ops_mpi.cpp b/modules/test_tasks/test_mpi/ops_mpi.cpp
@@ -60,7 +60,7 @@ int getParallelOperations(std::vector<int> global_vec,
 
     int global_sum = 0;
     int local_sum = getSequentialOperations(local_vec, ops);
-    MPI_Op op_code;
+    MPI_Op op_code = MPI_OP_NULL;
     if (ops == "+" || ops == "-") { op_code = MPI_SUM; }
     if (ops == "max") { op_code = MPI_MAX; }
     MPI_Reduce(&local_sum, &global_sum, 1, MPI_INT, op_code, 0, MPI_COMM_WORLD);
diff --git a/modules/test_tasks/test_omp/CMakeLists.txt b/modules/test_tasks/test_omp/CMakeLists.txt
@@ -17,6 +17,30 @@ if ( USE_OMP )
 
     enable_testing()
     add_test(NAME ${ProjectId} COMMAND ${ProjectId})
+
+    if( UNIX )
+        file(GLOB_RECURSE ALL_SOURCE_FILES *.cpp *.h)
+        foreach (SOURCE_FILE ${ALL_SOURCE_FILES})
+            string(FIND ${SOURCE_FILE} ${PROJECT_BINARY_DIR} PROJECT_TRDPARTY_DIR_FOUND)
+            if (NOT ${PROJECT_TRDPARTY_DIR_FOUND} EQUAL -1)
+                list(REMOVE_ITEM ALL_SOURCE_FILES ${SOURCE_FILE})
+            endif ()
+        endforeach ()
+
+        find_program(CPPCHECK cppcheck)
+        add_custom_target(
+                "${ProjectId}_cppcheck" ALL
+                COMMAND ${CPPCHECK}
+                --enable=warning,performance,portability,information,missingInclude
+                --language=c++
+                --std=c++11
+                --error-exitcode=1
+                --template="[{severity}][{id}] {message} {callstack} \(On {file}:{line}\)"
+                --verbose
+                --quiet
+                ${ALL_SOURCE_FILES}
+        )
+    endif( UNIX )
 else( USE_OMP )
     message( STATUS "-- ${ProjectId} - NOT BUILD!"  )
 endif( USE_OMP )
diff --git a/modules/test_tasks/test_seq/CMakeLists.txt b/modules/test_tasks/test_seq/CMakeLists.txt
@@ -17,6 +17,30 @@ if ( USE_SEQ )
 
     enable_testing()
     add_test(NAME ${ProjectId} COMMAND ${ProjectId})
+
+    if( UNIX )
+        file(GLOB_RECURSE ALL_SOURCE_FILES *.cpp *.h)
+        foreach (SOURCE_FILE ${ALL_SOURCE_FILES})
+            string(FIND ${SOURCE_FILE} ${PROJECT_BINARY_DIR} PROJECT_TRDPARTY_DIR_FOUND)
+            if (NOT ${PROJECT_TRDPARTY_DIR_FOUND} EQUAL -1)
+                list(REMOVE_ITEM ALL_SOURCE_FILES ${SOURCE_FILE})
+            endif ()
+        endforeach ()
+
+        find_program(CPPCHECK cppcheck)
+        add_custom_target(
+                "${ProjectId}_cppcheck" ALL
+                COMMAND ${CPPCHECK}
+                --enable=warning,performance,portability,information,missingInclude
+                --language=c++
+                --std=c++11
+                --error-exitcode=1
+                --template="[{severity}][{id}] {message} {callstack} \(On {file}:{line}\)"
+                --verbose
+                --quiet
+                ${ALL_SOURCE_FILES}
+        )
+    endif( UNIX )
 else( USE_SEQ )
     message( STATUS "-- ${ProjectId} - NOT BUILD!"  )
 endif( USE_SEQ )
diff --git a/modules/test_tasks/test_std/CMakeLists.txt b/modules/test_tasks/test_std/CMakeLists.txt
@@ -18,6 +18,30 @@ if ( USE_STD )
 
     enable_testing()
     add_test(NAME ${ProjectId} COMMAND ${ProjectId})
+
+    if( UNIX )
+        file(GLOB_RECURSE ALL_SOURCE_FILES *.cpp *.h)
+        foreach (SOURCE_FILE ${ALL_SOURCE_FILES})
+            string(FIND ${SOURCE_FILE} ${PROJECT_BINARY_DIR} PROJECT_TRDPARTY_DIR_FOUND)
+            if (NOT ${PROJECT_TRDPARTY_DIR_FOUND} EQUAL -1)
+                list(REMOVE_ITEM ALL_SOURCE_FILES ${SOURCE_FILE})
+            endif ()
+        endforeach ()
+
+        find_program(CPPCHECK cppcheck)
+        add_custom_target(
+                "${ProjectId}_cppcheck" ALL
+                COMMAND ${CPPCHECK}
+                --enable=warning,performance,portability,information,missingInclude
+                --language=c++
+                --std=c++11
+                --error-exitcode=1
+                --template="[{severity}][{id}] {message} {callstack} \(On {file}:{line}\)"
+                --verbose
+                --quiet
+                ${ALL_SOURCE_FILES}
+        )
+    endif( UNIX )
 else( USE_STD )
     message( STATUS "-- ${ProjectId} - NOT BUILD!"  )
 endif( USE_STD )
diff --git a/modules/test_tasks/test_tbb/CMakeLists.txt b/modules/test_tasks/test_tbb/CMakeLists.txt
@@ -22,6 +22,30 @@ if ( USE_TBB )
 
     enable_testing()
     add_test(NAME ${ProjectId} COMMAND ${ProjectId})
+
+    if( UNIX )
+        file(GLOB_RECURSE ALL_SOURCE_FILES *.cpp *.h)
+        foreach (SOURCE_FILE ${ALL_SOURCE_FILES})
+            string(FIND ${SOURCE_FILE} ${PROJECT_BINARY_DIR} PROJECT_TRDPARTY_DIR_FOUND)
+            if (NOT ${PROJECT_TRDPARTY_DIR_FOUND} EQUAL -1)
+                list(REMOVE_ITEM ALL_SOURCE_FILES ${SOURCE_FILE})
+            endif ()
+        endforeach ()
+
+        find_program(CPPCHECK cppcheck)
+        add_custom_target(
+                "${ProjectId}_cppcheck" ALL
+                COMMAND ${CPPCHECK}
+                --enable=warning,performance,portability,information,missingInclude
+                --language=c++
+                --std=c++11
+                --error-exitcode=1
+                --template="[{severity}][{id}] {message} {callstack} \(On {file}:{line}\)"
+                --verbose
+                --quiet
+                ${ALL_SOURCE_FILES}
+        )
+    endif( UNIX )
 else( USE_TBB )
     message( STATUS "-- ${ProjectId} - NOT BUILD!"  )
 endif( USE_TBB )
