Count course errors regardless of course idnumber

Author: justusdieckmann

managecategory.php

@@ -82,7 +82,7 @@
 
 $courseamounts = $DB->get_record_sql('SELECT (COUNT(evalc.id) - COUNT(evalmanualc.id)) as autoevalcourses, ' .
         'COUNT(evalmanualc.id) as manualevalcourses, COUNT(ereqc.id) as requestcourses, ' .
-        '(COUNT(*) - COUNT(COALESCE(ereqc.id, evalc.id))) as remainingcourses, COUNT(errors.id) as errorcourses ' .
+        '(COUNT(*) - COUNT(COALESCE(ereqc.id, evalc.id))) as remainingcourses ' .
         'FROM {course} c '  .
         'JOIN {customfield_data} cfd ON cfd.instanceid = c.id AND cfd.fieldid = :semesterfieldid ' .
         'LEFT JOIN {' . dbtables::EVAL_REQUESTS_COURSES . '} ereqc ON ereqc.courseid = c.id ' .
@@ -92,12 +92,21 @@
             JOIN {' . dbtables::EVAL_VERANSTS . '} evalver1 ON evalver1.evalid = c1.evalid ' .
             "WHERE evalver1.state $inmanualsql " .
         ') evalmanualc ON evalmanualc.courseid = c.id ' .
-        'LEFT JOIN {' . dbtables::ERRORS . '} errors ON errors.courseid = c.id AND errors.timehandled IS NULL ' .
         "WHERE cfd.intvalue = :semester AND " .
         "c.idnumber <> '' AND " .
         "c.category $incatsql ", array_merge(['semesterfieldid' => $field->id, 'semester' => $data->semester], $params)
 );
 
+$courseamountswithidnumber = $DB->get_record_sql('SELECT COUNT(errors.id) as errorcourses ' .
+        'FROM {course} c '  .
+        'JOIN {customfield_data} cfd ON cfd.instanceid = c.id AND cfd.fieldid = :semesterfieldid ' .
+        'LEFT JOIN {' . dbtables::ERRORS . '} errors ON errors.courseid = c.id AND errors.timehandled IS NULL ' .
+        "WHERE cfd.intvalue = :semester AND " .
+        "c.category $incatsql ", array_merge(['semesterfieldid' => $field->id, 'semester' => $data->semester], $params)
+);
+
+
+
 echo $OUTPUT->header();
 
 /* @var \block_evasys_sync\output\renderer $renderer  */
@@ -124,10 +133,10 @@
 
 $table->setup();
 
-if ($courseamounts->errorcourses) {
+if ($courseamountswithidnumber->errorcourses) {
     $table->add_data([
         html_writer::link(new moodle_url('/blocks/evasys_sync/managecategory_errors.php', ['id' => $id]),
-                get_string('courses_with_errors', 'block_evasys_sync')), $courseamounts->errorcourses
+                get_string('courses_with_errors', 'block_evasys_sync')), $courseamountswithidnumber->errorcourses
     ], 'table-warning');
 }