Skip to content

Commit d201e2c

Browse files
committed
fixed sql query and minified js files
1 parent 9b7de1a commit d201e2c

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

amd/build/initialize.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

amd/build/post_dialog.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

amd/build/standardtime.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

sync.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
if (optional_param('datedisabled', false, PARAM_BOOL)) {
3939
// We already have an evaluation request for this course: fetch the start- and enddates
4040
$sql = 'SELECT v.id, v.starttime, v.endtime, max(v.timemodified) as time FROM {' . \block_evasys_sync\dbtables::EVAL_VERANSTS . '} v INNER JOIN ' .
41-
'{' . \block_evasys_sync\dbtables::EVAL_COURSES . '} c on v.evalid=c.evalid WHERE c.courseid = :courseid ORDER BY time DESC';
41+
'{' . \block_evasys_sync\dbtables::EVAL_COURSES . '} c on v.evalid=c.evalid WHERE c.courseid = :courseid GROUP BY v.id, v.starttime ORDER BY time DESC';
4242
$record = $DB->get_record_sql($sql, ['courseid' => $courseid]);
4343
// $record = course_evaluation_allocation::get_record_by_course($courseid);
4444
$startdate = new \DateTime('@' . $record->starttime, \core_date::get_server_timezone_object());
@@ -49,7 +49,7 @@
4949
if (optional_param('only_end', false, PARAM_BOOL)) {
5050
// Existing start date should not be changed; just the end date. Fetch start date from record.
5151
$sql = 'SELECT v.id, v.starttime, max(v.timemodified) as time FROM {' . \block_evasys_sync\dbtables::EVAL_VERANSTS . '} v INNER JOIN ' .
52-
'{' . \block_evasys_sync\dbtables::EVAL_COURSES . '} c on v.evalid=c.evalid WHERE c.courseid = :courseid ORDER BY time DESC';
52+
'{' . \block_evasys_sync\dbtables::EVAL_COURSES . '} c on v.evalid=c.evalid WHERE c.courseid = :courseid GROUP BY v.id, v.starttime ORDER BY time DESC';
5353
$record = $DB->get_record_sql($sql, ['courseid' => $courseid]);
5454
$startdate = new \DateTime('@' . $record->starttime, \core_date::get_server_timezone_object());
5555
} else {

0 commit comments

Comments
 (0)