Fix capability for receiving email upon evasys coordinator planning eval

Author: justusdieckmann

classes/evaluation_manager.php

@@ -100,10 +100,10 @@ public static function set_default_evaluation_for($courseids, evasys_category $c
             ];
 
             $synchronizer->sync_students();
-            $teachers = get_users_by_capability(\context_course::instance($course->id), 'block/evasys_sync:getnotifiedteacher');
+            $teachers = get_users_by_capability(\context_course::instance($course->id), 'block/evasys_sync:teacherforcourse');
 
             $data = new \stdClass();
-            $data->coordinator = fullname($coordinatoruser);
+            $data->coordinator = $coordinatoruser->email;
             $data->start = userdate($category->get('standard_time_start'));
             $data->end = userdate($category->get('standard_time_end'));
             $data->courseshort = $course->shortname;

db/access.php

@@ -66,8 +66,7 @@
       'contextlevel' => CONTEXT_COURSE,
       'captype' => 'read',
       'archetypes' => [
-          'editingteacher' => CAP_ALLOW,
-          'manager' => CAP_PREVENT
+          'editingteacher' => CAP_ALLOW
       ]
   ]
 );

lang/de/block_evasys_sync.php

@@ -273,13 +273,13 @@
 $string['notify_teacher_email_subject'] = '{$a->courseshort}: Eine Evaluation wurde für Ihren Kurs geplant.';
 $string['notify_teacher_email_body'] = 'Sehr geehrte*r Lehrende*r,
 
-eine Evaluation wurde für Ihren Kurs {$a->coursefull}
+dies ist eine automatisch generierte Mail, ausgelöst dadurch, dass Ihr Evaluationskoordinator eine Evaluation für ihren Kurs <b>{$a->coursefull}</b>
 von {$a->start} bis {$a->end}
-geplant.
+geplant hat.
 
-Falls Sie Probleme mit dem Zeitraum der Evaluation haben, wenden Sie sich bitte an Ihre*n Evaluationskoordinator*in {$a->coordinator}.
+Bei Fragen oder Rückmeldungen wenden Sie sich bitte an Ihre*n Evaluationskoordinator*in via {$a->coordinator}.
 
-Mit freundlichen Grüßen,
+Mit freundlichen Grüßen
 Ihr Learnweb-Support';
 
 $string['request_eval'] = 'Evaluation beantragen';

lang/en/block_evasys_sync.php

@@ -284,11 +284,11 @@
 $string['notify_teacher_email_subject'] = '{$a->courseshort}: A evaluation was planned for your course.';
 $string['notify_teacher_email_body'] = 'Dear teacher,
 
-an evaluation was planned for your course {$a->coursefull}
+this is an automatically generated mail, caused by you evasys coordinator planning an evaluation for your course <b>{$a->coursefull}</b>
 from {$a->start}
 to {$a->end}.
 
-If this evaluation doesn\'t suit you at all, please contact your evasys coordinator {$a->coordinator}.
+In case of questions or issues regarding this evaluation, please contact your evasys coordinator via {$a->coordinator}.
 
 Sincerely,
 Your Learnweb-Support';