Fix privacy testcase

Author: justusdieckmann

tests/generator/lib.php

@@ -233,7 +233,7 @@ public function create_post($record = null, $straighttodb = true) {
         if ($straighttodb) {
             $record->id = $DB->insert_record('moodleoverflow_posts', $record);
         } else {
-            $record->id = moodleoverflow_add_new_post($record, );
+            $record->id = moodleoverflow_add_new_post($record);
         }
         // Update the last post.
         moodleoverflow_discussion_update_last_post($record->discussion);
@@ -369,18 +369,17 @@ public function post_to_discussion($forum, $discussion, $author) {
      *
      * @param stdClass $parent  The parent post
      * @param stdClass $author  The author to post as
+     * @param bool $straighttodb
      *
      * @return stdClass The new moodleoverflow post
      */
-    public function reply_to_post($parent, $author) {
+    public function reply_to_post($parent, $author, $straighttodb = true) {
         // Add a post to the discussion.
         $record = (object) [
             'discussion' => $parent->discussion,
             'parent'     => $parent->id,
             'userid'     => $author->id
         ];
-        $post = $this->create_post($record, false);
-
-        return $post;
+        return $this->create_post($record, $straighttodb);
     }
 }

tests/review_test.php

@@ -125,8 +125,8 @@ public function test_forum_review_everything() {
 
         $this->messagesink->clear();
 
-        $studentanswer1 = $this->generator->reply_to_post($teacherpost, $this->student);
-        $studentanswer2 = $this->generator->reply_to_post($teacherpost, $this->student);
+        $studentanswer1 = $this->generator->reply_to_post($teacherpost, $this->student, false);
+        $studentanswer2 = $this->generator->reply_to_post($teacherpost, $this->student, false);
 
         $this->run_send_mails();
         $this->run_send_mails(); // Execute twice to ensure no duplicate mails.
@@ -200,8 +200,8 @@ public function test_forum_review_only_questions() {
 
         $this->messagesink->clear();
 
-        $studentanswer1 = $this->generator->reply_to_post($teacherpost, $this->student);
-        $studentanswer2 = $this->generator->reply_to_post($teacherpost, $this->student);
+        $studentanswer1 = $this->generator->reply_to_post($teacherpost, $this->student, false);
+        $studentanswer2 = $this->generator->reply_to_post($teacherpost, $this->student, false);
 
         $this->assert_matches_properties(['mailed' => MOODLEOVERFLOW_MAILED_PENDING, 'reviewed' => 1, 'timereviewed' => null],
             $DB->get_record('moodleoverflow_posts', ['id' => $studentanswer1->id]));
@@ -254,8 +254,8 @@ public function test_forum_review_disallowed() {
         $this->mailsink->clear();
         $this->messagesink->clear();
 
-        $studentanswer1 = $this->generator->reply_to_post($teacherpost, $this->student);
-        $studentanswer2 = $this->generator->reply_to_post($teacherpost, $this->student);
+        $studentanswer1 = $this->generator->reply_to_post($teacherpost, $this->student, false);
+        $studentanswer2 = $this->generator->reply_to_post($teacherpost, $this->student, false);
 
         $this->assert_matches_properties(['mailed' => MOODLEOVERFLOW_MAILED_PENDING, 'reviewed' => 1, 'timereviewed' => null],
             $DB->get_record('moodleoverflow_posts', ['id' => $studentanswer1->id]));