fix unit tests

Author: NinaHerrmann

backup/moodle2/restore_moodleoverflow_activity_task.class.php

@@ -95,9 +95,9 @@ public static function define_decode_rules() {
 
     /**
      * Define the restore log rules that will be applied
-     * by the {@link restore_logs_processor} when restoring
+     * by the {restore_logs_processor} when restoring
      * moodleoverflow logs. It must return one array
-     * of {@link restore_log_rule} objects
+     * of { restore_log_rule} objects
      */
     public static function define_restore_log_rules() {
         $rules = array();
@@ -151,9 +151,9 @@ public static function define_restore_log_rules() {
 
     /**
      * Define the restore log rules that will be applied
-     * by the {@link restore_logs_processor} when restoring
+     * by the { restore_logs_processor} when restoring
      * course logs. It must return one array
-     * of {@link restore_log_rule} objects
+     * of { restore_log_rule} objects
      *
      * Note this rules are applied when restoring course logs
      * by the restore final task, but are defined here at

backup/moodle2/restore_moodleoverflow_stepslib.php

@@ -36,7 +36,7 @@ class restore_moodleoverflow_activity_structure_step extends restore_activity_st
     /**
      * Defines structure of path elements to be processed during the restore.
      *
-     * @return array of {@link restore_path_element}
+     * @return array of {restore_path_element}
      */
     protected function define_structure() {
 

lib.php

@@ -86,7 +86,7 @@
 /**
  * Returns the information on whether the module supports a feature.
  *
- * See {@link plugin_supports()} for more info.
+ * See {plugin_supports()} for more info.
  *
  * @param string $feature FEATURE_xx constant for requested feature
  *
@@ -359,7 +359,7 @@ function moodleoverflow_get_extra_capabilities() {
  * Returns the lists of all browsable file areas within the given module context.
  *
  * The file area 'intro' for the activity introduction field is added automatically
- * by {@link file_browser::get_file_info_context_module()}
+ * by { file_browser::get_file_info_context_module()}
  *
  * @param stdClass $course
  * @param stdClass $cm

tests/privacy_provider_test.php

@@ -20,10 +20,11 @@
  * @copyright  2018 Tamara Gunkel
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
+namespace mod_moodleoverflow;
+
 defined('MOODLE_INTERNAL') || die();
-global $CFG;
 
-namespace mod_moodleoverflow;
+global $CFG;
 
 use core_privacy\local\request\approved_contextlist;
 use \core_privacy\local\request\userlist;
@@ -898,7 +899,7 @@ protected function create_courses_and_modules($count) {
      * course.
      * Users are enrolled as students.
      *
-     * @param stdClass $course The course object
+     * @param  \stdClass $course The course object
      * @param integer  $count  The number of users to create
      *
      * @return array The users created
@@ -917,7 +918,7 @@ protected function create_users($course, $count) {
     /**
      * Creates and enrols users.
      *
-     * @param stdClass $course The course to enrol users.
+     * @param  \stdClass $course The course to enrol users.
      * @param int $count The number of users to create.
      *
      * @return array The users created
@@ -1430,7 +1431,7 @@ public function test_grades() {
                 'gradescalefactor' => 2
         ]);
         $cm = get_coursemodule_from_instance('moodleoverflow', $forum->id);
-        $context = context_module::instance($cm->id);
+        $context = \context_module::instance($cm->id);
 
         list($user, $user2) = $this->create_and_enrol_users($course, 2);
         list( , $post) = $this->generator->post_to_forum($forum, $user);

tests/review_test.php

@@ -45,15 +45,15 @@ class review_test extends \advanced_testcase {
     /** @var \mod_moodleoverflow_generator $generator */
     private $generator;
     /**
-     * @var \stdClass
+     * @var  \stdClass
      */
     private $teacher;
     /**
-     * @var \stdClass
+     * @var  \stdClass
      */
     private $student;
     /**
-     * @var \stdClass
+     * @var  \stdClass
      */
     private $course;
     /**

tests/subscriptions_test.php

@@ -61,7 +61,7 @@ public function tearDown(): void {
      * Helper to create the required number of users in the specified course.
      * Users are enrolled as students.
      *
-     * @param stdClass $course The course object
+     * @param  \stdClass $course The course object
      * @param int      $count  The number of users to create
      *
      * @return array The users created
@@ -81,8 +81,8 @@ protected function helper_create_users($course, $count) {
     /**
      * Crate a new discussion and post within the moodleoverflow.
      *
-     * @param stdClass $moodleoverflow The moodleoverflow to post in
-     * @param stdClass $author         The author to post as
+     * @param  \stdClass $moodleoverflow The moodleoverflow to post in
+     * @param  \stdClass $author         The author to post as
      *
      * @return array Array containing the discussion object and the post object.
      */
@@ -93,7 +93,7 @@ protected function helper_post_to_moodleoverflow($moodleoverflow, $author) {
         $generator = $this->getDataGenerator()->get_plugin_generator('mod_moodleoverflow');
 
         // Create a discussion in the moodleoverflow, add a post to that discussion.
-        $record = new stdClass();
+        $record = new  \stdClass();
         $record->course = $moodleoverflow->course;
         $record->userid = $author->id;
         $record->moodleoverflow = $moodleoverflow->id;
@@ -119,7 +119,7 @@ public function test_subscription_modes() {
         $course = $this->getDataGenerator()->create_course();
         $options = array('course' => $course->id);
         $moodleoverflow = $this->getDataGenerator()->create_module('moodleoverflow', $options);
-        $modulecontext = context_module::instance($moodleoverflow->cmid);
+        $modulecontext = \context_module::instance($moodleoverflow->cmid);
 
         // Create a user enrolled in the course as a student.
         list ($user) = $this->helper_create_users($course, 1);
@@ -927,7 +927,7 @@ public function test_fetch_subscribed_users_discussion_subscriptions() {
         $this->assertEquals($usercount, count($subscribers));
 
         // Manually insert an extra subscription for one of the users.
-        $record = new stdClass();
+        $record = new  \stdClass();
         $record->userid = $users[2]->id;
         $record->moodleoverflow = $moodleoverflow->id;
         $record->discussion = $discussion->id;
@@ -1406,7 +1406,7 @@ public function test_is_subscribable_logged_out($options) {
         $moodleoverflow = $this->getDataGenerator()->create_module('moodleoverflow', $options);
 
         $this->assertFalse(\mod_moodleoverflow\subscriptions::is_subscribable($moodleoverflow,
-                context_module::instance($moodleoverflow->cmid)));
+                \context_module::instance($moodleoverflow->cmid)));
     }
 
     /**
@@ -1430,7 +1430,7 @@ public function test_is_subscribable_is_guest($options) {
         $moodleoverflow = $this->getDataGenerator()->create_module('moodleoverflow', $options);
 
         $this->assertFalse(\mod_moodleoverflow\subscriptions::is_subscribable($moodleoverflow,
-                context_module::instance($moodleoverflow->cmid)));
+                \context_module::instance($moodleoverflow->cmid)));
     }
 
     /**
@@ -1481,6 +1481,6 @@ public function test_is_subscribable_loggedin($options, $expect) {
         $this->setUser($user);
 
         $this->assertEquals($expect, \mod_moodleoverflow\subscriptions::is_subscribable($moodleoverflow,
-                context_module::instance($moodleoverflow->cmid)));
+                \context_module::instance($moodleoverflow->cmid)));
     }
 }