sorting error fixed in ratings.php

Author: TamaroWalter

classes/ratings.php

@@ -242,11 +242,12 @@ public static function moodleoverflow_sort_answers_by_ratings($posts) {
         $sortedposts[0] = $parentpost;
 
         // Check if solved posts are preferred over helpful posts.
-        $solutionspreferred = $posts[array_key_first($posts)]->ratingpreference == 1;
-        var_dump('start');
-        var_dump($posts);
-        // Sort the answer posts by ratings.
+        $solutionspreferred = false;
+        if ($posts[array_key_first($posts)]->ratingpreference == 1) {
+            $solutionspreferred = true;
+        }
 
+        // Sort the answer posts by ratings.
         // Build groups of different types of answers (Solved and helpful, only solved/helpful, other).
         // statusteacher == 1 means the post is marked as solved.
         // statusstarter == 1 means the post is marked as helpful.
@@ -343,15 +344,12 @@ public static function moodleoverflow_sort_answers_by_ratings($posts) {
         }
 
         // Rearrange the indices and return the sorted posts.
-        var_dump('sortedpost');
-        var_dump($sortedposts);
 
         $neworder = array();
         foreach ($sortedposts as $post) {
             $neworder[$post->id] = $post;
         }
-        var_dump('neworder');
-        var_dump($neworder);
+ 
         // return now the sorted posts.
         return $neworder;
     }
@@ -831,7 +829,7 @@ private static function moodleoverflow_quicksort_post_by_votes(array &$posts, $l
             }
             if ($left <= $right) {
                 $temp = $posts[$right];
-                $post[$right] = $posts[$left];
+                $posts[$right] = $posts[$left];
                 $posts[$left] = $temp;
                 $right--;
                 $left++;