fix helpicon

Author: TamaroWalter

Diff for: classes/output/helpicon.php

@@ -42,18 +42,22 @@ class helpicon {
      */
     public function __construct($htmlclass, $content) {
         global $CFG;
-        $iconurl = $CFG->wwwroot . '/pix/a/help.png';
-        $icon = \html_writer::img($iconurl, $content);
+        $iconurl = $CFG->wwwroot . '/pix/a/help.svg';
+        $iconstyle = ['style' =>
+                      'max-width: 20px; max-height: 20px; margin: 0; padding: 0; box-sizing: content-box; margin-right: .5rem;'];
+        $icon = \html_writer::img($iconurl, $content, $iconstyle);
+        //                           'style' => 'display: inline-block; max-width: 100%; max-height: 100%;',
         $class = $htmlclass;
         $iconattributes = ['role' => 'button',
-                                    'data-container' => 'body',
-                                    'data-toggle' => 'popover',
-                                    'data-placement' => 'right',
-                                    'data-action' => 'showhelpicon',
-                                    'data-html' => 'true',
-                                    'data-trigger' => 'focus',
-                                    'tabindex' => '0',
-                                    'data-content' => '<div class=&quot;no-overflow&quot;><p>' . $content . '</p> </div>', ];
+                           'style' => 'display: inline;',
+                           'data-container' => 'body',
+                           'data-toggle' => 'popover',
+                           'data-placement' => 'right',
+                           'data-action' => 'showhelpicon',
+                           'data-html' => 'true',
+                           'data-trigger' => 'focus',
+                           'tabindex' => '0',
+                           'data-content' => '<div class=&quot;no-overflow&quot;><p>' . $content . '</p> </div>', ];
         $this->helpobject = \html_writer::span($icon, $class, $iconattributes);
     }
 

Diff for: classes/tables/userstats_table.php

@@ -157,7 +157,10 @@ public function set_helpactivity() {
         $content = get_string('helpamountofactivity', 'moodleoverflow');
         $helpobject = new helpicon($htmlclass, $content);
         $this->helpactivity = new \stdClass();
-        $this->helpactivity->iconurl = $CFG->wwwroot . '/pix/a/help.png';
+        $this->helpactivity->object = $helpobject->get_helpicon();
+        /*
+        $this->helpactivity = new \stdClass();
+        $this->helpactivity->iconurl = $CFG->wwwroot . '/pix/a/help.svg';
         $this->helpactivity->icon = \html_writer::img($this->helpactivity->iconurl,
                                                       get_string('helpamountofactivity', 'moodleoverflow'));
         $this->helpactivity->class = 'helpactivityclass btn btn-link';
@@ -175,7 +178,7 @@ public function set_helpactivity() {
 
         $this->helpactivity->object = \html_writer::span($this->helpactivity->icon,
                                                          $this->helpactivity->class,
-                                                         $this->helpactivity->iconattributes);
+                                                         $this->helpactivity->iconattributes);*/
     }
 
     // Functions that show the data.

Diff for: locallib.php

@@ -1527,7 +1527,7 @@ function moodleoverflow_print_post($post, $discussion, $moodleoverflow, $cm, $co
  * @param stdClass $limitedanswersetting Two Unix timestamp wrapped in a stdClass, upper and lower label for answering.
  * @return bool
  */
-function is_currently_time_limited($limitedanswersetting) {
+function is_currently_time_limited($limitedanswersetting) : bool {
     return ($limitedanswersetting->la_starttime != 0 && $limitedanswersetting->la_starttime > time())
     || ($limitedanswersetting->la_endtime != 0 && $limitedanswersetting->la_endtime < time());
 }
@@ -1559,6 +1559,7 @@ function render_limited_answer($htmlattributes, &$commands, $infolimited, $role,
         'attributes' => $limitedanswerattributes,
         'limitedanswer' => $role, ];
 }
+
 /**
  * Prints all posts of the discussion in a nested form.
  *