Only allow voting and replying when post is reviewed

Author: justusdieckmann

amd/build/reviewing.min.js

@@ -33,8 +33,6 @@ export function init() {
     Prefetch.prefetchStrings('mod_moodleoverflow',
         ['post_was_approved', 'jump_to_next_post_needing_review', 'there_are_no_posts_needing_review', 'post_was_rejected']);
 
-    window.console.log('INIT1!');
-
     const root = document.getElementById('moodleoverflow-posts');
     root.onclick = async(e) => {
         const action = e.target.getAttribute('data-moodleoverflow-action');
@@ -43,8 +41,6 @@ export function init() {
             return;
         }
 
-        window.console.log('INIT!');
-
         const post = e.target.closest('*[data-moodleoverflow-postid]');
         const reviewRow = e.target.closest('.reviewrow');
         const postID = post.getAttribute('data-moodleoverflow-postid');
@@ -67,6 +63,7 @@ export function init() {
                 message += await getString('there_are_no_posts_needing_review', 'mod_moodleoverflow');
             }
             reviewRow.innerHTML = message;
+            post.classList.remove("pendingreview");
         } else if (action === 'reject') {
             reviewRow.innerHTML = '.';
             reviewRow.innerHTML = await Templates.render('mod_moodleoverflow/reject_post_form', {});

amd/build/reviewing.min.js.map

@@ -82,7 +82,7 @@ public static function moodleoverflow_add_rating($moodleoverflow, $postid, $rati
         $coursecontext = \context_course::instance($course->id);
 
         // Redirect the user if capabilities are missing.
-        $canrate = self::moodleoverflow_user_can_rate($moodleoverflow, $cm, $modulecontext, $userid);
+        $canrate = self::moodleoverflow_user_can_rate($post, $modulecontext, $userid);
         if (!$canrate) {
 
             // Catch unenrolled users.
@@ -784,13 +784,12 @@ private static function moodleoverflow_update_rating_record($postid, $rating, $u
      * Check if a user can rate the post.
      *
      * @param object $moodleoverflow
-     * @param null   $cm
-     * @param null   $modulecontext
+     * @param \context_module   $modulecontext
      * @param null|int $userid
      *
      * @return bool
      */
-    private static function moodleoverflow_user_can_rate($moodleoverflow, $cm = null, $modulecontext = null, $userid = null) {
+    private static function moodleoverflow_user_can_rate($post, $modulecontext, $userid = null) {
         global $USER;
         if (!$userid) {
             // Guests and non-logged-in users can not rate.
@@ -800,20 +799,8 @@ private static function moodleoverflow_user_can_rate($moodleoverflow, $cm = null
             $userid = $USER->id;
         }
 
-        // Retrieve the coursemodule.
-        if (!$cm) {
-            if (!$cm = get_coursemodule_from_instance('moodleoverflow', $moodleoverflow->id, $moodleoverflow->course)) {
-                throw new moodle_exception('invalidcoursemodule');
-            }
-        }
-
-        // Get the context if not set in the parameters.
-        if (!$modulecontext) {
-            $modulecontext = context_module::instance($cm->id);
-        }
-
         // Check the capability.
-        return has_capability('mod/moodleoverflow:ratepost', $modulecontext, $userid);
+        return has_capability('mod/moodleoverflow:ratepost', $modulecontext, $userid) && $post->reviewed == 1;
     }
 
 }

amd/src/reviewing.js

@@ -98,7 +98,7 @@ public static function get_first_review_post($afterpostid = null) {
             $addwhere = ' AND id != :notpostid ';
             $params['notpostid'] = $afterpostid;
         }
-        $record =  $DB->get_record_sql(
+        $record = $DB->get_record_sql(
             'SELECT id as postid, discussion as discussionid FROM {moodleoverflow_posts} ' .
             "WHERE reviewed = 0 $addwhere " .
             "ORDER BY $orderby discussion, id " .