WIP: tests for limitedanswer

Author: TamaroWalter

mod_form.php

@@ -261,13 +261,13 @@ public function definition() {
         $mform->setType('la_answersfound', PARAM_BOOL);
         $mform->addElement('date_time_selector', 'la_starttime', get_string('la_starttime', 'moodleoverflow'),
                 ['optional' => true]);
-        //$mform->setType('la_starttime', PARAM_INT);
+
         $mform->addHelpButton('la_starttime', 'la_starttime', 'moodleoverflow');
         $mform->disabledIf('la_starttime', 'la_answersfound', 'eq', true);
 
         $mform->addElement('date_time_selector', 'la_endtime', get_string('la_endtime', 'moodleoverflow'),
             ['optional' => true]);
-        //$mform->setType('la_endtime', PARAM_INT);
+
         $mform->addHelpButton('la_endtime', 'la_endtime', 'moodleoverflow');
 
         $mform->addElement('hidden', 'la_error');
@@ -294,6 +294,13 @@ public function data_postprocessing($data) {
         }
     }
 
+    /**
+     * Validates set data in mod_form
+     * @param $data
+     * @param $files
+     * @return array
+     * @throws coding_exception
+     */
     public function validation($data, $files) {
         $errors = parent::validation($data, $files);
 
@@ -307,7 +314,7 @@ public function validation($data, $files) {
         }
         if ($isendtime) {
             if ($data['la_endtime'] < $currenttime) {
-                $errors['la_endtime'] =  get_string('la_endtime_ruleerror', 'moodleoverflow');
+                $errors['la_endtime'] = get_string('la_endtime_ruleerror', 'moodleoverflow');
             }
 
             if ($isstarttime && $data['la_endtime'] <= $data['la_starttime']) {

tests/behat/limitedanswer.feature

@@ -44,4 +44,16 @@
       | Message | This is the answer message |
     And I press "Post to forum"
     Then I should see "This is the answer message"
-     And I should see "This is the question message"
+     And I should see "This is the question message"
+
+  Scenario: Setting up the limited answer mode, the times need to be in order and in the future.
+    Given the following "activities" exist:
+      | activity       | name                      | intro                            | course  |  idnumber |
+      | moodleoverflow | Test Moodleoverflow       | Test moodleoverflow description  | C1      |  1        |
+    And I log in as "teacher1"
+    And I am on "Course 1" course homepage
+    And I follow "Test Moodleoverflow"
+    And I follow "Settings"
+    And I follow "Limited Answer Mode"
+    And
+    And I pause