Fix step and trigger reordering: only change the relevant workflow (#200)

Author: olivabigyo

classes/local/manager/step_manager.php

@@ -137,8 +137,8 @@ private static function remove_from_sortindex(&$toberemoved) {
         global $DB;
         if (isset($toberemoved->sortindex)) {
             $subplugins = $DB->get_records_select('tool_lifecycle_step',
-                "sortindex > $toberemoved->sortindex",
-                ['workflowid' => $toberemoved->workflowid]);
+                'workflowid = :workflowid AND sortindex > :sortindex',
+                ['workflowid' => $toberemoved->workflowid, 'sortindex' => $toberemoved->sortindex]);
             foreach ($subplugins as $record) {
                 $subplugin = step_subplugin::from_record($record);
                 $subplugin->sortindex--;

classes/local/manager/trigger_manager.php

@@ -179,8 +179,8 @@ private static function remove_from_sortindex(&$toberemoved) {
         global $DB;
         if (isset($toberemoved->sortindex)) {
             $subplugins = $DB->get_records_select('tool_lifecycle_trigger',
-                "sortindex > $toberemoved->sortindex",
-                ['workflowid' => $toberemoved->workflowid]);
+                'workflowid = :workflowid AND sortindex > :sortindex',
+                ['workflowid' => $toberemoved->workflowid, 'sortindex' => $toberemoved->sortindex]);
             foreach ($subplugins as $record) {
                 $subplugin = trigger_subplugin::from_record($record);
                 $subplugin->sortindex--;