Remove all now apparently unwanted MOODLE_INTERNAL checks

justusdieckmann · justusdieckmann · commit 7b977434b8d6 · 2022-01-13T22:31:48.000+01:00
diff --git a/classes/action.php b/classes/action.php
@@ -22,8 +22,6 @@
  */
 namespace tool_lifecycle;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Delivers all available action names throughout the plugin.
  * @package    tool_lifecycle
diff --git a/classes/event/process_proceeded.php b/classes/event/process_proceeded.php
@@ -26,8 +26,6 @@
 use moodle_url;
 use tool_lifecycle\local\entity\process;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The process_proceeded event class.
  *
diff --git a/classes/event/process_rollback.php b/classes/event/process_rollback.php
@@ -27,8 +27,6 @@
 use moodle_url;
 use tool_lifecycle\local\entity\process;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The process_rollback event class.
  *
diff --git a/classes/event/process_triggered.php b/classes/event/process_triggered.php
@@ -27,8 +27,6 @@
 use moodle_url;
 use tool_lifecycle\local\entity\process;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * The process_triggered event class.
  *
diff --git a/classes/local/backup/backup_lifecycle_workflow.php b/classes/local/backup/backup_lifecycle_workflow.php
@@ -31,8 +31,6 @@
 use tool_lifecycle\local\manager\settings_manager;
 use tool_lifecycle\settings_type;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Class to backup a workflow.
  * @package    tool_lifecycle
diff --git a/classes/local/backup/restore_lifecycle_workflow.php b/classes/local/backup/restore_lifecycle_workflow.php
@@ -31,8 +31,6 @@
 use tool_lifecycle\local\manager\settings_manager;
 use tool_lifecycle\settings_type;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Class to restore a workflow.
  * @package    tool_lifecycle
diff --git a/classes/local/data/manual_trigger_tool.php b/classes/local/data/manual_trigger_tool.php
@@ -25,8 +25,6 @@
 
 use renderable;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Class representing a manual trigger tool
  *
diff --git a/classes/local/entity/process.php b/classes/local/entity/process.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\local\entity;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Life Cycle Process class
  *
diff --git a/classes/local/entity/step_subplugin.php b/classes/local/entity/step_subplugin.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\local\entity;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Subplugin class
  *
diff --git a/classes/local/entity/subplugin.php b/classes/local/entity/subplugin.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\local\entity;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Subplugin class
  *
diff --git a/classes/local/entity/trigger_subplugin.php b/classes/local/entity/trigger_subplugin.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\local\entity;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Trigger subplugin class
  *
diff --git a/classes/local/entity/workflow.php b/classes/local/entity/workflow.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\local\entity;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Life Cycle Workflow class
  *
diff --git a/classes/local/manager/delayed_courses_manager.php b/classes/local/manager/delayed_courses_manager.php
@@ -24,7 +24,6 @@
  */
 namespace tool_lifecycle\local\manager;
 
-defined('MOODLE_INTERNAL') || die();
 /**
  * Manager for Delayed Courses.
  *
diff --git a/classes/local/manager/interaction_manager.php b/classes/local/manager/interaction_manager.php
@@ -27,8 +27,6 @@
 use tool_lifecycle\processor;
 use tool_lifecycle\local\response\step_interactive_response;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Manager to handle interactions by users
  *
diff --git a/classes/local/manager/lib_manager.php b/classes/local/manager/lib_manager.php
@@ -28,8 +28,6 @@
 use tool_lifecycle\trigger\base_automatic;
 use tool_lifecycle\trigger\base_manual;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Manager to retrive the lib of each subplugin.
  *
diff --git a/classes/local/manager/process_data_manager.php b/classes/local/manager/process_data_manager.php
@@ -30,8 +30,6 @@
 use tool_lifecycle\local\entity\process;
 use tool_lifecycle\local\entity\trigger_subplugin;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Manager for data of Life Cycle Processes.
  *
diff --git a/classes/local/manager/process_manager.php b/classes/local/manager/process_manager.php
@@ -29,8 +29,6 @@
 use tool_lifecycle\event\process_proceeded;
 use tool_lifecycle\event\process_rollback;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Manager for Life Cycle Processes
  *
diff --git a/classes/local/manager/step_manager.php b/classes/local/manager/step_manager.php
@@ -27,8 +27,6 @@
 use tool_lifecycle\local\entity\step_subplugin;
 use tool_lifecycle\settings_type;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Manager for Subplugins
  *
diff --git a/classes/local/manager/subplugin_manager.php b/classes/local/manager/subplugin_manager.php
@@ -23,22 +23,6 @@
  */
 namespace tool_lifecycle\local\manager;
 
-defined('MOODLE_INTERNAL') || die();
-// This file is part of Moodle - http://moodle.org/
-//
-// Moodle is free software: you can redistribute it and/or modify
-// it under the terms of the GNU General Public License as published by
-// the Free Software Foundation, either version 3 of the License, or
-// (at your option) any later version.
-//
-// Moodle is distributed in the hope that it will be useful,
-// but WITHOUT ANY WARRANTY; without even the implied warranty of
-// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-// GNU General Public License for more details.
-//
-// You should have received a copy of the GNU General Public License
-// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
-
 /**
  * Manager for Subplugins
  *
diff --git a/classes/local/manager/trigger_manager.php b/classes/local/manager/trigger_manager.php
@@ -28,8 +28,6 @@
 use tool_lifecycle\local\entity\workflow;
 use tool_lifecycle\settings_type;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Manager for Trigger subplugins
  *
diff --git a/classes/local/manager/workflow_manager.php b/classes/local/manager/workflow_manager.php
@@ -30,8 +30,6 @@
 use tool_lifecycle\local\data\manual_trigger_tool;
 use tool_lifecycle\settings_type;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Manager for Life Cycle Workflows
  *
diff --git a/classes/local/response/step_interactive_response.php b/classes/local/response/step_interactive_response.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\local\response;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Possible Responses of a Subplugin for interaction handling
  *
diff --git a/classes/local/response/step_response.php b/classes/local/response/step_response.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\local\response;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Possible Responses of a Subplugin
  *
diff --git a/classes/local/response/trigger_response.php b/classes/local/response/trigger_response.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\local\response;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Possible Responses of a Trigger Subplugin
  *
diff --git a/classes/plugininfo/lifecyclestep.php b/classes/plugininfo/lifecyclestep.php
@@ -27,8 +27,6 @@
 use tool_lifecycle\local\manager\step_manager;
 use tool_lifecycle\local\manager\workflow_manager;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Pluginfo for life cycle step
  *
diff --git a/classes/plugininfo/lifecycletrigger.php b/classes/plugininfo/lifecycletrigger.php
@@ -30,8 +30,6 @@
 use tool_lifecycle\local\manager\workflow_manager;
 use tool_usertours\step;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Pluginfo for life cycle trigger
  *
diff --git a/classes/privacy/provider.php b/classes/privacy/provider.php
@@ -35,8 +35,6 @@
 use tool_lifecycle\local\manager\step_manager;
 use tool_lifecycle\local\manager\workflow_manager;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Implementation of the privacy subsystem plugin provider for the Life Cycle tool.
  *
diff --git a/classes/processor.php b/classes/processor.php
@@ -35,9 +35,6 @@
 use tool_lifecycle\local\response\step_response;
 use tool_lifecycle\local\response\trigger_response;
 
-
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Offers functionality to trigger, process and finish lifecycle processes.
  *
diff --git a/classes/settings_type.php b/classes/settings_type.php
@@ -22,8 +22,6 @@
  */
 namespace tool_lifecycle;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Defines available settings_types.
  * @package    tool_lifecycle
diff --git a/classes/task/lifecycle_cleanup_task.php b/classes/task/lifecycle_cleanup_task.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\task;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Scheduled task for cleanup past delays
  *
diff --git a/classes/task/lifecycle_error_notify_task.php b/classes/task/lifecycle_error_notify_task.php
@@ -23,8 +23,6 @@
  */
 namespace tool_lifecycle\task;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Scheduled task for notify admin upon process errors
  *
diff --git a/classes/task/lifecycle_task.php b/classes/task/lifecycle_task.php
@@ -27,8 +27,6 @@
 use tool_lifecycle\local\manager\step_manager;
 use tool_lifecycle\processor;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Scheduled task for working on lifecycle processes
  *
diff --git a/classes/view_controller.php b/classes/view_controller.php
@@ -32,9 +32,7 @@
 use tool_lifecycle\local\manager\trigger_manager;
 use tool_lifecycle\local\table\interaction_log_table;
 use tool_lifecycle\local\table\interaction_remaining_table;
-use tool_lifecycle\local\table\interaction_attention_table;
-
-defined('MOODLE_INTERNAL') || die();
+use tool_lifecycle\local\table\interaction_attention_table;;
 
 /**
  * Controller for view.php
diff --git a/db/upgrade.php b/db/upgrade.php
@@ -22,8 +22,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Update script for tool_lifecycle.
  * @param int $oldversion Version id of the previously installed version.
diff --git a/lib.php b/lib.php
@@ -21,8 +21,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Adds a tool_lifecycle link to the course admin menu.
  *
diff --git a/renderer.php b/renderer.php
@@ -21,7 +21,6 @@
  * @copyright  2017 Tobias Reischmann WWU
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-defined('MOODLE_INTERNAL') || die();
 
 /**
  * Renderer for life cycle
diff --git a/step/createbackup/db/upgrade.php b/step/createbackup/db/upgrade.php
@@ -25,8 +25,6 @@
 use tool_lifecycle\local\manager\settings_manager;
 use tool_lifecycle\local\manager\step_manager;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Update script for lifecycles subplugin createbackup.
  * @param int $oldversion Version id of the previously installed version.
diff --git a/step/deletecourse/db/upgrade.php b/step/deletecourse/db/upgrade.php
@@ -25,8 +25,6 @@
 use tool_lifecycle\local\manager\settings_manager;
 use tool_lifecycle\local\manager\step_manager;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Update script for lifecycles subplugin deletecourse
  *
diff --git a/step/interactionlib.php b/step/interactionlib.php
@@ -31,8 +31,6 @@
 use tool_lifecycle\local\entity\step_subplugin;
 use tool_lifecycle\local\response\step_interactive_response;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Interface for the interactions of the subplugintype step.
  *
diff --git a/tests/active_workflow_is_manual_test.php b/tests/active_workflow_is_manual_test.php
@@ -22,7 +22,6 @@
  * @copyright  2018 WWU
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-defined('MOODLE_INTERNAL') || die();
 
 require_once(__DIR__ . '/generator/lib.php');
 require_once(__DIR__ . '/../lib.php');
diff --git a/tests/backup_manager_test.php b/tests/backup_manager_test.php
@@ -22,7 +22,6 @@
  * @copyright  2017 Tobias Reischmann WWU
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-defined('MOODLE_INTERNAL') || die();
 
 use tool_lifecycle\local\manager\backup_manager;
 
diff --git a/tests/generator/lib.php b/tests/generator/lib.php
@@ -22,7 +22,6 @@
  * @copyright  2017 Tobias Reischmann WWU
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-defined('MOODLE_INTERNAL') || die();
 
 use tool_lifecycle\local\entity\process;
 use tool_lifecycle\local\entity\trigger_subplugin;
diff --git a/tests/manual_trigger_tools_test.php b/tests/manual_trigger_tools_test.php
@@ -22,7 +22,6 @@
  * @copyright  2018 Tobias Reischmann, Jan Dageforde WWU
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
-defined('MOODLE_INTERNAL') || die();
 
 use tool_lifecycle\action;
 use tool_lifecycle\local\entity\workflow;
diff --git a/tests/persistence/persist_process_data_test.php b/tests/persistence/persist_process_data_test.php
diff --git a/tests/persistence/persist_step_test.php b/tests/persistence/persist_step_test.php
diff --git a/tests/persistence/persist_workflow_test.php b/tests/persistence/persist_workflow_test.php
diff --git a/tests/process_status_message_test.php b/tests/process_status_message_test.php
diff --git a/trigger/categories/tests/generator/lib.php b/trigger/categories/tests/generator/lib.php
diff --git a/trigger/delayedcourses/db/install.php b/trigger/delayedcourses/db/install.php
diff --git a/trigger/delayedcourses/tests/generator/lib.php b/trigger/delayedcourses/tests/generator/lib.php
diff --git a/trigger/sitecourse/db/install.php b/trigger/sitecourse/db/install.php
diff --git a/trigger/sitecourse/tests/generator/lib.php b/trigger/sitecourse/tests/generator/lib.php
diff --git a/trigger/startdatedelay/tests/generator/lib.php b/trigger/startdatedelay/tests/generator/lib.php

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,6 @@`
`26`	`26`	`use moodle_url;`
`27`	`27`	`use tool_lifecycle\local\entity\process;`
`28`	`28`
`29`		`-defined('MOODLE_INTERNAL') \|\| die();`
`30`		`-`
`31`	`29`	`/**`
`32`	`30`	`* The process_proceeded event class.`
`33`	`31`	`*`
Original file line number	Diff line number	Diff line change
`@@ -27,8 +27,6 @@`
`27`	`27`	`use moodle_url;`
`28`	`28`	`use tool_lifecycle\local\entity\process;`
`29`	`29`
`30`		`-defined('MOODLE_INTERNAL') \|\| die();`
`31`		`-`
`32`	`30`	`/**`
`33`	`31`	`* The process_rollback event class.`
`34`	`32`	`*`
Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,6 @@`
`25`	`25`
`26`	`26`	`use renderable;`
`27`	`27`
`28`		`-defined('MOODLE_INTERNAL') \|\| die();`
`29`		`-`
`30`	`28`	`/**`
`31`	`29`	`* Class representing a manual trigger tool`
`32`	`30`	`*`
Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,6 @@`
`23`	`23`	`*/`
`24`	`24`	`namespace tool_lifecycle\local\entity;`
`25`	`25`
`26`		`-defined('MOODLE_INTERNAL') \|\| die();`
`27`		`-`
`28`	`26`	`/**`
`29`	`27`	`* Life Cycle Process class`
`30`	`28`	`*`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@`
`24`	`24`	`*/`
`25`	`25`	`namespace tool_lifecycle\local\manager;`
`26`	`26`
`27`		`-defined('MOODLE_INTERNAL') \|\| die();`
`28`	`27`	`/**`
`29`	`28`	`* Manager for Delayed Courses.`
`30`	`29`	`*`
Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,6 @@`
`28`	`28`	`use tool_lifecycle\trigger\base_automatic;`
`29`	`29`	`use tool_lifecycle\trigger\base_manual;`
`30`	`30`
`31`		`-defined('MOODLE_INTERNAL') \|\| die();`
`32`		`-`
`33`	`31`	`/**`
`34`	`32`	`* Manager to retrive the lib of each subplugin.`
`35`	`33`	`*`
Original file line number	Diff line number	Diff line change
`@@ -30,8 +30,6 @@`
`30`	`30`	`use tool_lifecycle\local\entity\process;`
`31`	`31`	`use tool_lifecycle\local\entity\trigger_subplugin;`
`32`	`32`
`33`		`-defined('MOODLE_INTERNAL') \|\| die();`
`34`		`-`
`35`	`33`	`/**`
`36`	`34`	`* Manager for data of Life Cycle Processes.`
`37`	`35`	`*`
Original file line number	Diff line number	Diff line change
`@@ -29,8 +29,6 @@`
`29`	`29`	`use tool_lifecycle\event\process_proceeded;`
`30`	`30`	`use tool_lifecycle\event\process_rollback;`
`31`	`31`
`32`		`-defined('MOODLE_INTERNAL') \|\| die();`
`33`		`-`
`34`	`32`	`/**`
`35`	`33`	`* Manager for Life Cycle Processes`
`36`	`34`	`*`
Original file line number	Diff line number	Diff line change
`@@ -35,8 +35,6 @@`
`35`	`35`	`use tool_lifecycle\local\manager\step_manager;`
`36`	`36`	`use tool_lifecycle\local\manager\workflow_manager;`
`37`	`37`
`38`		`-defined('MOODLE_INTERNAL') \|\| die();`
`39`		`-`
`40`	`38`	`/**`
`41`	`39`	`* Implementation of the privacy subsystem plugin provider for the Life Cycle tool.`
`42`	`40`	`*`
Original file line number	Diff line number	Diff line change
`@@ -35,9 +35,6 @@`
`35`	`35`	`use tool_lifecycle\local\response\step_response;`
`36`	`36`	`use tool_lifecycle\local\response\trigger_response;`
`37`	`37`
`38`		`-`
`39`		`-defined('MOODLE_INTERNAL') \|\| die;`
`40`		`-`
`41`	`38`	`/**`
`42`	`39`	`* Offers functionality to trigger, process and finish lifecycle processes.`
`43`	`40`	`*`