From 4c9c5328f9bdf724ae0642d44d91e81d83cf43ec Mon Sep 17 00:00:00 2001 From: Fara Woolf Date: Mon, 19 Feb 2024 15:52:03 -0600 Subject: [PATCH] fix: attempt to fix failing test --- test-app/src/components/profile.tsx | 10 ++++----- tests/specs/profile/profile.spec.ts | 33 ++++++++++++----------------- 2 files changed, 19 insertions(+), 24 deletions(-) diff --git a/test-app/src/components/profile.tsx b/test-app/src/components/profile.tsx index a8b9023fa7c..036c3f89b1e 100644 --- a/test-app/src/components/profile.tsx +++ b/test-app/src/components/profile.tsx @@ -1,7 +1,7 @@ import React, { useState } from 'react'; import { useAuth } from '@common/use-auth'; -import { stacksMainnetNetwork } from '@common/utils'; +import { stacksMainnetNetwork, stacksTestnetNetwork } from '@common/utils'; import { openProfileUpdateRequestPopup } from '@stacks/connect'; import { StacksNetwork } from '@stacks/network'; import { PublicPersonProfile, PublicProfile } from '@stacks/profile'; @@ -70,11 +70,11 @@ export const Profile = () => { }, ], }, - stacksMainnetNetwork + stacksTestnetNetwork ) } > - Update profile (Mainnet) + Update profile (Testnet) { { name: 1, } as any, - stacksMainnetNetwork + stacksTestnetNetwork ) } > - Try to update invalid profile (Mainnet) + Try to update invalid profile (Testnet) diff --git a/tests/specs/profile/profile.spec.ts b/tests/specs/profile/profile.spec.ts index fe503453792..e04f3fa8aec 100644 --- a/tests/specs/profile/profile.spec.ts +++ b/tests/specs/profile/profile.spec.ts @@ -1,4 +1,3 @@ -import { Page } from '@playwright/test'; import { TestAppPage } from '@tests/page-object-models/test-app.page'; import { UpdateProfileRequestPage } from '@tests/page-object-models/update-profile-request.page'; @@ -9,19 +8,6 @@ test.describe.configure({ mode: 'serial' }); test.describe('Profile updating', () => { let testAppPage: TestAppPage; - function interceptGaiaRequest(page: Page): Promise { - return new Promise(resolve => { - page.on('request', request => { - if (request.url().startsWith('https://hub.blockstack.org/store')) { - const requestBody = request.postDataBuffer(); - if (request.method() === 'GET') return; - if (requestBody === null) return; - resolve(requestBody); - } - }); - }); - } - test.beforeEach(async ({ extensionId, globalPage, onboardingPage, context }) => { await globalPage.setupAndUseApiCalls(extensionId); await onboardingPage.signInWithTestAccount(extensionId); @@ -57,12 +43,21 @@ test.describe('Profile updating', () => { await testAppPage.clickUpdateProfileButton(); const profileUpdatingPage = new UpdateProfileRequestPage(await context.waitForEvent('page')); - const [gaiaRequestBody] = await Promise.all([ - interceptGaiaRequest(profileUpdatingPage.page), - profileUpdatingPage.clickUpdateProfileButton(), - ]); + const requestPromise = profileUpdatingPage.page.waitForRequest('https://hub.blockstack.org/*'); + + await profileUpdatingPage.page.route('https://hub.blockstack.org/*', async route => { + await route.abort(); + }); + + await profileUpdatingPage.clickUpdateProfileButton(); + + const request = await requestPromise; + const requestBody = request.postDataBuffer(); + if (!requestBody) return; + + const { decodedToken } = JSON.parse(requestBody.toString())[0]; - const { decodedToken } = JSON.parse(gaiaRequestBody.toString())[0]; + test.expect(decodedToken).toBeDefined(); test.expect(decodedToken?.header?.alg).toEqual('ES256K'); test.expect(decodedToken?.payload?.claim?.name).toContain('Name ');