From c3919fa3aa2940aaa0eb4f3803e011d0cf005e30 Mon Sep 17 00:00:00 2001 From: alter-eggo Date: Mon, 25 Dec 2023 13:44:10 +0400 Subject: [PATCH] fix: nan total amount bug --- src/app/common/math/calculate-averages.spec.ts | 3 +++ src/app/common/math/calculate-averages.ts | 1 + 2 files changed, 4 insertions(+) diff --git a/src/app/common/math/calculate-averages.spec.ts b/src/app/common/math/calculate-averages.spec.ts index 157619330c5..b6aeacd66d5 100644 --- a/src/app/common/math/calculate-averages.spec.ts +++ b/src/app/common/math/calculate-averages.spec.ts @@ -3,6 +3,9 @@ import BigNumber from 'bignumber.js'; import { calculateMeanAverage } from './calculate-averages'; describe(calculateMeanAverage.name, () => { + test('it calculates average of 0', () => + expect(calculateMeanAverage([]).toString()).toEqual('0')); + test('it calculates averages of 1', () => expect(calculateMeanAverage([new BigNumber(1)]).toString()).toEqual('1')); diff --git a/src/app/common/math/calculate-averages.ts b/src/app/common/math/calculate-averages.ts index 605bba7585e..7f8a15b73a9 100644 --- a/src/app/common/math/calculate-averages.ts +++ b/src/app/common/math/calculate-averages.ts @@ -3,6 +3,7 @@ import BigNumber from 'bignumber.js'; import { initBigNumber } from './helpers'; export function calculateMeanAverage(numbers: BigNumber[] | number[]) { + if (numbers.length === 0) return new BigNumber(0); return numbers .map(initBigNumber) .reduce((acc, price) => acc.plus(price), new BigNumber(0))