Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Fee gets cut off #5173

Closed
brandonmarshall-tm opened this issue Apr 5, 2024 · 6 comments · Fixed by #5197
Closed

Increase Fee gets cut off #5173

brandonmarshall-tm opened this issue Apr 5, 2024 · 6 comments · Fixed by #5197
Assignees
Labels
bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds needs:visual-improvement

Comments

@brandonmarshall-tm
Copy link

User-reported issue when a contract name is too long, the "Increase Fee" button gets cut off.

image

@314159265359879
Copy link
Contributor

Thanks adding.

Workaround: open the wallet in a new tab via the top right corner menu.

Lets check if this is resolved with the containers PR which is going out in the next release (Monday).

@314159265359879 314159265359879 added bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds needs:visual-improvement labels Apr 5, 2024
@kyranjamie
Copy link
Collaborator

The styles more generally look broken here. This is prod version @brandonmarshall-tm ?

@314159265359879
Copy link
Contributor

314159265359879 commented Apr 8, 2024

@kyranjamie This is on production, I see it too. (Chrome/Windows)

@pete-watters
Copy link
Contributor

I'm pretty sure this issue will be fixed once we do the next release which contains #4655.

As I can see the scrollbar in the screenshot I am guessing the user is using chrome on Windows. Lets check if it is still broken once we do the next release and if it is I can check it further.

It would be good to get some more details regarding the browser / OS

@markmhendrickson
Copy link
Collaborator

I believe the new containers work improves this issue in some regards, but it ends up cutting off "Increase" leaving just "Fee"

Screenshot 2024-03-22 at 17 43 30

@pete-watters
Copy link
Contributor

I fixed this and made sure we always say Increase Fee. We had some code there that was explicitly only showing Fee in popup mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Functionality broken bug-p3 Non-critical functionality broken for many users, or there are clear workarounds needs:visual-improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants