Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacements (aliases) for BL, MF and BQ #9

Closed
rangoo94 opened this issue Jan 5, 2016 · 4 comments
Closed

Replacements (aliases) for BL, MF and BQ #9

rangoo94 opened this issue Jan 5, 2016 · 4 comments

Comments

@rangoo94
Copy link
Contributor

rangoo94 commented Jan 5, 2016

These icons are missing - I will try to prepare these flags according to famfamfam style.

Also, it's worth to add aliases for BL, MF & BQ (BL = MF = FR, BQ = NL). I will investigate it further and eventually alias these countries.

I will make proper PR on evening.

@t1st3
Copy link
Collaborator

t1st3 commented Jan 5, 2016

@rangoo94 thanks for your suggestions, I'm all for them.
About aliases, since BL = MF = FR, it would not be sane to include 3 times the same flag. Although the spritesheet could be hacked with such information, what would you expect for an aliasing method of the icons

@rangoo94
Copy link
Contributor Author

rangoo94 commented Jan 5, 2016

@t1st3 not sure yet, I will review node-spritesheet to check if there is any proper method. If not, I would create small method with configurable aliases to replace such text (by e.g. gulp-replace).

Then for example input { "bl": "fr", "mf": "fr" } can create regular expression to change all occurrences of \.famfamfam-flags\.(bl|mf) to .famfamfam-flags.fr. These aliases should be in configuration JSON file, because that's just set of data.

@t1st3
Copy link
Collaborator

t1st3 commented Jan 5, 2016

Sounds good to me!
I don't know much of the internals of node-spritesheet, but I struggled recently to install it; I hope it won't be much a hassle for your PR!

rangoo94 added a commit to rangoo94/famfamfam-flags that referenced this issue Jan 11, 2016
@rangoo94 rangoo94 changed the title Missing CW, SX, IM, AQ icons, worth to know about BL, MF and BQ replacements Replacements (aliases) for BL, MF and BQ Jan 11, 2016
@rangoo94
Copy link
Contributor Author

I splitted this issue as I am not sure about quality of these icons; I will add more info at #13.

rangoo94 added a commit to rangoo94/famfamfam-flags that referenced this issue Jan 11, 2016
rangoo94 added a commit to rangoo94/famfamfam-flags that referenced this issue Jan 11, 2016
rangoo94 added a commit to rangoo94/famfamfam-flags that referenced this issue Jan 11, 2016
rangoo94 added a commit to rangoo94/famfamfam-flags that referenced this issue Jan 11, 2016
@t1st3 t1st3 closed this as completed in #16 Jan 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants