Merge pull request #3 from legionth/update-unittests

Use Mockbuilder instead of getMock for PHPUnit tests

Author: legionth

tests/LineReaderTest.php

@@ -7,7 +7,7 @@ class LineReaderTest extends TestCase
     public function setUp()
     {
         $this->lineReader = new LineReader();
-        
+
         $this->input = new ReadableStream();
         $this->input->pipe($this->lineReader);
     }
@@ -23,7 +23,7 @@ public function testMethodIsCalled()
     public function testSeperatedData()
     {
         $this->lineReader->on('data', $this->expectCallableOnceWith('helloworld' . PHP_EOL));
-        
+
         $this->input->emit('data', array(
             'hello'
         ));
@@ -35,7 +35,7 @@ public function testSeperatedData()
     public function testWithLineBreak()
     {
         $this->lineReader->on('data', $this->expectCallableOnceWith('hello' . PHP_EOL));
-        
+
         $this->input->emit('data', array(
             'hello' . PHP_EOL . 'world'
         ));
@@ -48,7 +48,7 @@ public function testDoubleLineBreak()
             'world' . PHP_EOL
         );
         $this->lineReader->on('data', $this->expectCallableConsecutive(2, $expectedValues));
-        
+
         $this->input->emit('data', array(
             'hello' . PHP_EOL . 'world' . PHP_EOL
         ));
@@ -69,10 +69,10 @@ public function testResumeStream()
 
     public function testPipeStream()
     {
-        $dest = $this->getMock('React\Stream\WritableStreamInterface');
-        
+        $dest = $this->getMockBuilder('React\Stream\WritableStreamInterface')->getMock();
+
         $ret = $this->lineReader->pipe($dest);
-        
+
         $this->assertSame($dest, $ret);
     }
 
@@ -92,15 +92,15 @@ public function testIsReadable()
     {
         $lineReader = new LineReader();
         $actual = $lineReader->isReadable();
-        
+
         $this->assertTrue($actual);
     }
 
     public function testIsWritable()
     {
         $lineReader = new LineReader();
         $actual = $lineReader->isWritable();
-        
+
         $this->assertTrue($actual);
     }
 
@@ -114,13 +114,13 @@ public function testStreamIsAlreadyClosed()
     private function expectCallableConsecutive($numberOfCalls, array $with)
     {
         $mock = $this->createCallableMock();
-        
+
         for ($i = 0; $i < $numberOfCalls; $i ++) {
             $mock->expects($this->at($i))
                 ->method('__invoke')
                 ->with($this->equalTo($with[$i]));
         }
-        
+
         return $mock;
     }
 }

tests/bootstrap.php

@@ -53,7 +53,7 @@ protected function expectCallableOnceParameter($type)
      */
     protected function createCallableMock()
     {
-        return $this->getMock('CallableStub');
+        return $this->getMockBuilder('CallableStub')->getMock();
     }
 }