Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag to loader for whether to load chromosome or supercontigs, or both #37

Open
alancleary opened this issue Dec 14, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@alancleary
Copy link
Collaborator

Without a flag it's just going to load whatever is in there. With a flag, you should provide a list of things you want it to pay attention to, i.e. chloroplasts. It there should be a finite set of one or more options for them to choose from, i.e. use a ArgParse choices parameter: https://docs.python.org/3/library/argparse.html#choices

@alancleary alancleary added the enhancement New feature or request label Dec 14, 2021
@adf-ncgr
Copy link
Contributor

It looks like someone did try to implement something along these lines, but at least with respect to the chado_loader it seems pretty broken. Not that anyone is likely to use the chado_loader for much of anything these days, but since I had to tussle with it briefly when dealing with some old arabidopsis datasets, I'll record a few observations that may be useful for later if we try to deal with it more properly:

  • the use of nargs="+" here is problematic given that (I think) the current structure of the command line requires the chado/gff arg to follow, along with their specific options
  • the customized EnvAction doesn't provide any obvious (to me) way of getting a list defined as this one requires
  • the downstream consumer is trying to iterate over a string because of the previous point, leading to errors about not finding cvterms with name 'c' (from 'chromosome')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants