fix: fixed registry settings subscriptions

Author: Leonardo Chaia

src/app/home/registry-cards/registry-cards.component.ts

@@ -1,26 +1,31 @@
-import { Component, OnInit } from '@angular/core';
+import { Component, OnInit, OnDestroy } from '@angular/core';
 import { SettingsService } from '../../settings/settings.service';
 import { TabService } from '../../tabs/tab.service';
 import { TimoneerTabs } from '../../timoneer-tabs';
+import { Subject } from 'rxjs';
+import { takeUntil } from 'rxjs/operators';
 
 @Component({
   selector: 'tim-registry-cards',
   templateUrl: './registry-cards.component.html',
   styleUrls: ['./registry-cards.component.scss']
 })
-export class RegistryCardsComponent implements OnInit {
+export class RegistryCardsComponent implements OnInit, OnDestroy {
 
   public loading: boolean;
 
   public registries: { name: string, url: string }[];
+  private componetDestroyed = new Subject();
 
   constructor(private settingsService: SettingsService,
     private tabService: TabService) { }
 
   public ngOnInit() {
 
+    this.registries = [];
     this.loading = true;
     this.settingsService.getSettings()
+      .pipe(takeUntil(this.componetDestroyed))
       .subscribe(settings => {
         this.registries = settings.registries
           .filter(r => r.allowsCatalog)
@@ -42,4 +47,9 @@ export class RegistryCardsComponent implements OnInit {
       params: registry
     });
   }
+
+  public ngOnDestroy() {
+    this.componetDestroyed.next();
+    this.componetDestroyed.unsubscribe();
+  }
 }

src/app/registry/registry.service.ts

@@ -65,6 +65,7 @@ export class RegistryService {
 
           return this.settingsService.getRegistrySettingsForUrl(registryUrl)
             .pipe(
+              take(1),
               switchMap(registrySettings => {
                 if (!registrySettings) {
                   return throwError(`Unauthorized, no registry settings found for registry [${registryUrl}]`);