Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Change to ERC721 creation instead of Identity tokens #36

Open
fricoben opened this issue Feb 25, 2023 · 1 comment
Open

Change to ERC721 creation instead of Identity tokens #36

fricoben opened this issue Feb 25, 2023 · 1 comment
Labels
Difficulty: hard require extensive knowledge about the field Duration: few days will take a few days Type: feature a new feature to implement

Comments

@fricoben
Copy link
Contributor

fricoben commented Feb 25, 2023

Is your feature request related to a problem? Please describe.

Right now, you can deploy an https://github.com/starknet-id/identity_tokens but we want to change that. We want for the moment to be able to deploy an ERC721 classic contract (with a proxy).

Describe the solution you'd like

You could be able to deploy two types of SBTs:
1 - An ERC721 with a max date (it means that everyone can mint it until X)
2 - An ERC721 with a Merkle root whitelist (it means that the admin needs to enter the whitelisted address and write it on-chain

A bit like what we have here:
Capture d’écran 2023-02-25 à 12 21 04

For this issue, you'll need to adapt the deployment part but also the mint page (that final users will use !)

Describe alternatives you've considered

The question that you could ask at the beginning is why did you started with identity_tokens instead of using ERC721 directly ? So the idea of identity tokens is that it is really soulbond (classic SBT are not in starknet because of Account Abstraction) but we briefly understood that if we continue that way we'll need to work on the adoption part cause people won't understand the difference between an ERC721 and an identity token.

So the idea for us here is only to use classic ERC721 contract that already exists and are supported everywhere (and we'll need to upgrade everything when cairo 1 will come out but it'll be easier cause we'll use open zeppelin contracts).

@fricoben fricoben added Available for contribution An issue that is available for an Only Dust contribution Type: feature a new feature to implement Duration: few days will take a few days Difficulty: hard require extensive knowledge about the field and removed Available for contribution An issue that is available for an Only Dust contribution labels Feb 25, 2023
@irisdv
Copy link
Contributor

irisdv commented Feb 26, 2023

Interested to work on this issue !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Difficulty: hard require extensive knowledge about the field Duration: few days will take a few days Type: feature a new feature to implement
Projects
None yet
Development

No branches or pull requests

2 participants