CSR review remarks

Author: liach

src/java.base/share/classes/java/lang/classfile/BufWriter.java

@@ -77,8 +77,8 @@ public sealed interface BufWriter
      * writing process may be slower.
      *
      * @apiNote
-     * This is a hint that has changes no visible state of the buffer; it helps
-     * to reduce reallocation of the underlying storage by allocating sufficient
+     * This is a hint that changes no visible state of the buffer; it helps to
+     * reduce reallocation of the underlying storage by allocating sufficient
      * space at once.
      *
      * @param freeBytes the number of bytes to reserve
@@ -111,8 +111,8 @@ public sealed interface BufWriter
     /**
      * Writes a float value, of 4 bytes, to the buffer.
      * <p>
-     * In the conversions, all NaN values of the {@code float} may be collapsed
-     * into a single {@linkplain Float#NaN "canonical" NaN value}.
+     * In the conversions, all NaN values of the {@code float} may or may not be
+     * collapsed into a single {@linkplain Float#NaN "canonical" NaN value}.
      *
      * @param x the float value
      */
@@ -128,8 +128,8 @@ public sealed interface BufWriter
     /**
      * Writes a double value, of 8 bytes, to the buffer.
      * <p>
-     * In the conversions, all NaN values of the {@code double} may be collapsed
-     * into a single {@linkplain Double#NaN "canonical" NaN value}.
+     * In the conversions, all NaN values of the {@code double} may or may not
+     * be collapsed into a single {@linkplain Double#NaN "canonical" NaN value}.
      *
      * @param x the double value
      */

src/java.base/share/classes/java/lang/classfile/ClassReader.java

@@ -196,8 +196,8 @@ public sealed interface ClassReader extends ConstantPool
      * {@return the float value at the specified offset within the {@code class}
      * file}  Reads 4 bytes of value.
      * <p>
-     * In the conversions, all NaN values of the {@code float} may be collapsed
-     * into a single {@linkplain Float#NaN "canonical" NaN value}.
+     * In the conversions, all NaN values of the {@code float} may or may not be
+     * collapsed into a single {@linkplain Float#NaN "canonical" NaN value}.
      *
      * @param offset the offset within the {@code class} file
      */
@@ -207,8 +207,8 @@ public sealed interface ClassReader extends ConstantPool
      * {@return the double value at the specified offset within the {@code
      * class} file}  Reads 8 bytes of value.
      * <p>
-     * In the conversions, all NaN values of the {@code double} may be collapsed
-     * into a single {@linkplain Double#NaN "canonical" NaN value}.
+     * In the conversions, all NaN values of the {@code double} may or may not
+     * be collapsed into a single {@linkplain Double#NaN "canonical" NaN value}.
      *
      * @param offset the offset within the {@code class} file
      */

src/java.base/share/classes/java/lang/classfile/Signature.java

@@ -57,7 +57,7 @@ public sealed interface Signature {
     String signatureString();
 
     /**
-     * Parses generic Java type signature from raw string.
+     * Parses a Java type signature from a raw string.
      *
      * @param javaTypeSignature raw Java type signature string
      * @return a Java type signature

src/java.base/share/classes/java/lang/classfile/attribute/CodeAttribute.java

@@ -38,7 +38,7 @@
  * AttributeMapper#allowMultiple multiple instances} in a method.  It has a
  * data dependency on the {@linkplain AttributeStability#CP_REFS constant pool}.
  * <p>
- * This attribute was introduced in the Java SE Platform version 1.0.2, major
+ * This attribute was introduced in the Java Platform version 1.0.2, major
  * version {@value ClassFile#JAVA_1_VERSION}.
  *
  * @apiNote

src/java.base/share/classes/java/lang/classfile/attribute/ConstantValueAttribute.java

@@ -46,7 +46,7 @@
  * AttributeMapper#allowMultiple multiple instances} in a field.  It has a
  * data dependency on the {@linkplain AttributeStability#CP_REFS constant pool}.
  * <p>
- * This attribute was introduced in the Java SE Platform version 1.0.2, major
+ * This attribute was introduced in the Java Platform version 1.0.2, major
  * version {@value ClassFile#JAVA_1_VERSION}.
  *
  * @see Attributes#constantValue()

src/java.base/share/classes/java/lang/classfile/attribute/ExceptionsAttribute.java

@@ -49,7 +49,7 @@
  * AttributeMapper#allowMultiple multiple instances} in a method.  It has a
  * data dependency on the {@linkplain AttributeStability#CP_REFS constant pool}.
  * <p>
- * The attribute was introduced in the Java SE Platform version 1.0.2, major
+ * The attribute was introduced in the Java Platform version 1.0.2, major
  * version {@value ClassFile#JAVA_1_VERSION}.
  *
  * @apiNote

src/java.base/share/classes/java/lang/classfile/attribute/LineNumberTableAttribute.java

@@ -53,7 +53,7 @@
  * constructed with {@link LineNumber}, resulting in at most one attribute
  * instance in the built {@code Code} attribute.
  * <p>
- * The attribute was introduced in the Java SE Platform version 1.0.2, major
+ * The attribute was introduced in the Java Platform version 1.0.2, major
  * version {@value ClassFile#JAVA_1_VERSION}.
  *
  * @see Attributes#lineNumberTable()

src/java.base/share/classes/java/lang/classfile/attribute/LocalVariableTableAttribute.java

@@ -53,7 +53,7 @@
  * constructed with {@link LocalVariable}, resulting in at most one attribute
  * instance in the built {@code Code} attribute.
  * <p>
- * The attribute was introduced in the Java SE Platform version 1.0.2, major
+ * The attribute was introduced in the Java Platform version 1.0.2, major
  * version {@value ClassFile#JAVA_1_VERSION}.
  *
  * @apiNote

src/java.base/share/classes/java/lang/classfile/constantpool/DoubleEntry.java

@@ -34,8 +34,8 @@
  * <p>
  * The use of a {@code DoubleEntry} is modeled by a {@code double}.  Conversions
  * are through {@link ConstantPoolBuilder#doubleEntry} and {@link #doubleValue()}.
- * In the conversions, all NaN values of the {@code double} may be collapsed
- * into a single {@linkplain Double#NaN "canonical" NaN value}.
+ * In the conversions, all NaN values of the {@code double} may or may not be
+ * collapsed into a single {@linkplain Double#NaN "canonical" NaN value}.
  * <p>
  * A double entry has a {@linkplain #width() width} of {@code 2}, making its
  * subsequent constant pool index valid and unusable.

src/java.base/share/classes/java/lang/classfile/constantpool/FloatEntry.java

@@ -34,8 +34,8 @@
  * <p>
  * The use of a {@code FloatEntry} is modeled by a {@code float}.  Conversions
  * are through {@link ConstantPoolBuilder#floatEntry} and {@link #floatValue()}.
- * In the conversions, all NaN values of the {@code float} may be collapsed into
- * a single {@linkplain Float#NaN "canonical" NaN value}.
+ * In the conversions, all NaN values of the {@code float} may or may not be
+ * collapsed into a single {@linkplain Float#NaN "canonical" NaN value}.
  *
  * @see ConstantPoolBuilder#floatEntry ConstantPoolBuilder::floatEntry
  * @jvms 4.4.4 The {@code CONSTANT_Integer_info} and {@code CONSTANT_Float_info}