Skip to content

Commit a0d1a47

Browse files
committed
Correctly set aria-hidden value
1 parent 1a4d51d commit a0d1a47

File tree

2 files changed

+11
-12
lines changed

2 files changed

+11
-12
lines changed

responsive-nav.js

+8-9
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ var responsiveNav = (function (window, document) {
3737
var nav,
3838
opts,
3939
navToggle,
40-
aria = "aria-hidden",
4140
docEl = document.documentElement,
4241
head = document.getElementsByTagName("head")[0],
4342
styleElement = document.createElement("style"),
@@ -200,7 +199,7 @@ var responsiveNav = (function (window, document) {
200199
removeClass(nav, "closed");
201200
removeClass(nav, "opened");
202201
nav.removeAttribute("style");
203-
nav.removeAttribute(aria);
202+
nav.removeAttribute("aria-hidden");
204203
nav = null;
205204
_instance = null;
206205

@@ -214,7 +213,7 @@ var responsiveNav = (function (window, document) {
214213
if (!opts.customToggle) {
215214
navToggle.parentNode.removeChild(navToggle);
216215
} else {
217-
navToggle.removeAttribute(aria);
216+
navToggle.removeAttribute("aria-hidden");
218217
}
219218

220219
if (styleElement.parentNode) {
@@ -229,7 +228,7 @@ var responsiveNav = (function (window, document) {
229228
removeClass(nav, "closed");
230229
addClass(nav, "opened");
231230
nav.style.position = opts.openPos;
232-
setAttributes(nav, {"aria": "false"});
231+
setAttributes(nav, {"aria-hidden": "false"});
233232

234233
navOpen = true;
235234
opts.open();
@@ -238,7 +237,7 @@ var responsiveNav = (function (window, document) {
238237
} else {
239238
removeClass(nav, "opened");
240239
addClass(nav, "closed");
241-
setAttributes(nav, {"aria": "true"});
240+
setAttributes(nav, {"aria-hidden": "true"});
242241

243242
if (opts.animate) {
244243
setTimeout(function () {
@@ -385,10 +384,10 @@ var responsiveNav = (function (window, document) {
385384
opts.init();
386385

387386
if (window.getComputedStyle(navToggle, null).getPropertyValue("display") !== "none") {
388-
setAttributes(navToggle, {"aria": "false"});
387+
setAttributes(navToggle, {"aria-hidden": "false"});
389388

390389
if (nav.className.match(/(^|\s)closed(\s|$)/)) {
391-
setAttributes(nav, {"aria": "true"});
390+
setAttributes(nav, {"aria-hidden": "true"});
392391
nav.style.position = "absolute";
393392
}
394393

@@ -406,8 +405,8 @@ var responsiveNav = (function (window, document) {
406405

407406
log("Calculated max-height of " + savedHeight + "px and updated 'styleElement'");
408407
} else {
409-
setAttributes(navToggle, {"aria": "true"});
410-
setAttributes(nav, {"aria": "false"});
408+
setAttributes(navToggle, {"aria-hidden": "true"});
409+
setAttributes(nav, {"aria-hidden": "false"});
411410
nav.style.position = opts.openPos;
412411
this._removeStyles();
413412
}

responsive-nav.min.js

+3-3
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)