pylint: update to 3.2 for Python 3.11

To migrate the codebase to newer Python, we need to update pylint
to run with newer Python versions.  Bump it to vpython 3.11 and a
newer Pylint 3.2.

Make some minor code changes to fix new warnings from the new version.

Change-Id: Ieab91f27ca84669601f004d4b380a873e0dc908d
Reviewed-on: https://chromium-review.googlesource.com/c/apps/libapps/+/6201551
Reviewed-by: Joel Hockey <[email protected]>
Tested-by: kokoro <[email protected]>

Author: vapier

.pylintrc

@@ -2,21 +2,17 @@
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
-[MASTER]
+[MAIN]
 
 # Use multiple processes to speed up Pylint.
 jobs = 0
 
 # List of plugins (as comma separated values of python modules names) to load,
 # usually to register additional checkers.
 load-plugins=
+    pylint.extensions.bad_builtin,
     pylint.extensions.docstyle,
 
-# Configure quote preferences.
-string-quote = single-avoid-escape
-triple-quote = double
-docstring-quote = double
-
 
 [MESSAGES CONTROL]
 
@@ -25,13 +21,11 @@ disable=
     duplicate-code,
     fixme,
     invalid-name,
-    locally-enabled,
     locally-disabled,
     no-else-break,
     no-else-continue,
     no-else-return,
     not-callable,
-    relative-import,
     too-few-public-methods,
     too-many-arguments,
     too-many-branches,
@@ -67,10 +61,8 @@ bad-functions=
     apply,
     exit,
     filter,
-    input,
     map,
     quit,
-    raw_input,
     reduce,
 
 

libdot/bin/libdot.py

@@ -80,7 +80,7 @@ def setup_logging(debug=False, quiet=0):
         level = logging.WARNING
     elif quiet <= 2:
         level = logging.ERROR
-    elif quiet <= 3:
+    else:  # if quiet <= 3:
         level = logging.CRITICAL
 
     formatter = ColoredFormatter(fmt, datefmt)
@@ -119,7 +119,10 @@ def parse_known_args(self, args=None, namespace=None):
 
     def add_common_arguments(self, short_options=True):
         """Add our custom/consistent set of command line flags."""
-        getopts = lambda *args: args if short_options else args[1:]
+
+        def getopts(*args):
+            return args if short_options else args[1:]
+
         self.add_argument(
             *getopts("-d", "--debug"),
             action="store_true",

libdot/bin/pylint-vpython

@@ -9,18 +9,14 @@
 # network to see if there are any updates.
 
 # [VPYTHON:BEGIN]
-# python_version: "3.8"
+# python_version: "3.11"
 #
 # # Third party dependencies.  These are only listed because pylint itself needs
 # # them.  Feel free to add/remove anything here.
 #
 # wheel: <
 #   name: "infra/python/wheels/dill-py3"
-#   version: "version:0.3.4"
-# >
-# wheel: <
-#   name: "infra/python/wheels/futures-py3"
-#   version: "version:3.1.1"
+#   version: "version:0.3.7"
 # >
 # wheel: <
 #   name: "infra/python/wheels/isort-py3"
@@ -32,42 +28,22 @@
 # >
 # wheel: <
 #   name: "infra/python/wheels/platformdirs-py3"
-#   version: "version:2.5.2"
-# >
-# wheel: <
-#   name: "infra/python/wheels/six-py3"
-#   version: "version:1.15.0"
-# >
-# wheel: <
-#   name: "infra/python/wheels/toml-py3"
-#   version: "version:0.10.1"
-# >
-# wheel: <
-#   name: "infra/python/wheels/tomli-py3"
-#   version: "version:2.0.1"
-# >
-# wheel: <
-#   name: "infra/python/wheels/wrapt/${vpython_platform}"
-#   version: "version:1.12.1"
-# >
-# wheel: <
-#   name: "infra/python/wheels/lazy-object-proxy/${vpython_platform}"
-#   version: "version:1.4.3"
+#   version: "version:3.10.0"
 # >
 # wheel: <
-#   name: "infra/python/wheels/typing-extensions-py3"
-#   version: "version:4.0.1"
+#   name: "infra/python/wheels/tomlkit-py3"
+#   version: "version:0.12.3"
 # >
 #
 # # Pylint dependencies.
 #
 # wheel: <
 #   name: "infra/python/wheels/astroid-py3"
-#   version: "version:2.11.3"
+#   version: "version:3.2.4"
 # >
 # wheel: <
 #   name: "infra/python/wheels/pylint-py3"
-#   version: "version:2.13.8"
+#   version: "version:3.2.7"
 # >
 #
 # # Random deps we use in the tree.