chai: update to v5

This version only ships ES6 modules, so we need to tweak how it's
imported & used.

Change-Id: I2f1ea444d072dc815717f69170e1951010383f54
Reviewed-on: https://chromium-review.googlesource.com/c/apps/libapps/+/6217759
Reviewed-by: Joel Hockey <[email protected]>
Tested-by: kokoro <[email protected]>

Author: vapier

hterm/html/hterm_test.html

@@ -4,7 +4,6 @@
     <meta charset='utf-8'/>
 
     <!-- npm modules -->
-    <script src='../../node_modules/chai/chai.js'></script>
     <script src='../../node_modules/mocha/mocha.js'></script>
 
     <!-- initialize the test framework; this must come first -->

hterm/js/hterm_test.js

@@ -4,14 +4,17 @@
 
 /**
  * @fileoverview Test framework setup when run inside the browser.
+ * @suppress {moduleLoad} closure compiler can't handle node_modules/.
  */
 
+import {assert} from '../../node_modules/chai/chai.js';
+
 // Setup the mocha framework.
 mocha.setup('bdd');
 mocha.checkLeaks();
 
 // Add a global shortcut to the assert API.
-globalThis['assert'] = chai.assert;
+globalThis['assert'] = assert;
 
 // Catch any random errors before the test runner runs.
 let earlyError = null;

hterm/package.json

@@ -29,7 +29,7 @@
   },
   "devDependencies": {
     "@rollup/plugin-node-resolve": "~15",
-    "chai": "~4",
+    "chai": "~5",
     "eslint": "~8",
     "mocha": "~11",
     "mocha-headless-chrome": "~4",

libdot/bin/node

@@ -16,7 +16,7 @@ import libdot
 # The hash of the node_modules that we maintain.
 # Allow a long line for easy automated updating.
 NODE_MODULES_HASH = (
-    "f54d402945ab7d7be9cc882249ace797e392b24abbbf3ea20feeb6b71d6c4ea8"
+    "d384bf88a099d6b1f1140c8eefee178d1b6923fda2fe8d0a9f0055a44acd171f"
 )
 
 # In sync with Chromium's DEPS file because it's easier to use something that

libdot/html/lib_test.html

@@ -4,7 +4,6 @@
     <meta charset='utf-8'/>
 
     <!-- npm modules -->
-    <script src='../../node_modules/chai/chai.js'></script>
     <script src='../../node_modules/mocha/mocha.js'></script>
 
     <!-- initialize the test framework; this must come first -->

libdot/js/lib_test.js

@@ -4,14 +4,17 @@
 
 /**
  * @fileoverview Test framework setup when run inside the browser.
+ * @suppress {moduleLoad} closure compiler can't handle node_modules/.
  */
 
+import {assert} from '../../node_modules/chai/chai.js';
+
 // Setup the mocha framework.
 mocha.setup('bdd');
 mocha.checkLeaks();
 
 // Add a global shortcut to the assert API.
-globalThis['assert'] = chai.assert;
+globalThis['assert'] = assert;
 
 // Catch any random errors before the test runner runs.
 let earlyError = null;

libdot/package.json

@@ -26,7 +26,7 @@
     "test": "./bin/load_tests"
   },
   "devDependencies": {
-    "chai": "~4",
+    "chai": "~5",
     "eslint": "~8",
     "mocha": "~11",
     "mocha-headless-chrome": "~4",

nassh/html/nassh_test.html

@@ -4,7 +4,6 @@
     <meta charset='utf-8'/>
 
     <!-- npm modules -->
-    <script src='../../node_modules/chai/chai.js'></script>
     <script src='../../node_modules/mocha/mocha.js'></script>
 
     <!-- initialize the test framework; this must come first -->

nassh/js/nassh_test.js

@@ -4,14 +4,17 @@
 
 /**
  * @fileoverview Test framework setup when run inside the browser.
+ * @suppress {moduleLoad} closure compiler can't handle node_modules/.
  */
 
+import {assert} from '../../node_modules/chai/chai.js';
+
 // Setup the mocha framework.
 mocha.setup('bdd');
 mocha.checkLeaks();
 
 // Add a global shortcut to the assert API.
-globalThis['assert'] = chai.assert;
+globalThis['assert'] = assert;
 
 // Catch any random errors before the test runner runs.
 let earlyError = null;

nassh/package.json

@@ -31,7 +31,7 @@
   "devDependencies": {
     "@rollup/plugin-node-resolve": "~15",
     "@rollup/plugin-terser": "~0",
-    "chai": "~4",
+    "chai": "~5",
     "eslint": "~8",
     "http-server": "~14",
     "license-checker": "~25",

package.json

@@ -26,7 +26,7 @@
     "@rollup/plugin-terser": "~0",
     "@rollup/plugin-url": "~8",
     "@rollup/plugin-yaml": "~4",
-    "@types/chai": "~4",
+    "@types/chai": "~5",
     "@types/chrome": "~0",
     "@types/filesystem": "~0",
     "@types/filewriter": "~0",
@@ -35,7 +35,7 @@
     "@types/punycode": "~2",
     "@types/trusted-types": "~2",
     "asn1js": "~2",
-    "chai": "~4",
+    "chai": "~5",
     "csso": ">=5",
     "csso-cli": ">=4",
     "eslint": "~8",

terminal/html/terminal_test.html

@@ -6,11 +6,10 @@
     <link rel="icon" href="../images/empty.svg" type="image/svg+xml">
 
     <!-- npm modules -->
-    <script src='../../node_modules/chai/chai.js'></script>
     <script src='../../node_modules/mocha/mocha.js'></script>
 
     <!-- Initialize the test framework first. -->
-    <script src='../js/terminal_test_preload.js'></script>
+    <script type='module' src='../js/terminal_test_preload.js'></script>
     <script type='module' src='../js/terminal_test.js'></script>
 
     <!-- All the unittests go below here. -->

terminal/js/terminal_test_preload.js

@@ -4,7 +4,10 @@
 
 /**
  * @fileoverview Test framework setup when run inside the browser.
+ * @suppress {moduleLoad} closure compiler can't handle node_modules/.
  */
 
+import {assert} from '../../node_modules/chai/chai.js';
+
 // Add a global shortcut to the assert API.
-globalThis['assert'] = chai.assert;
+globalThis['assert'] = assert;

wasi-js-bindings/test/index.html

@@ -4,7 +4,6 @@
     <meta charset='utf-8'/>
 
     <!-- npm modules -->
-    <script src='../../node_modules/chai/chai.js'></script>
     <script src='../../node_modules/mocha/mocha.js'></script>
 
     <!-- Initialize the test framework; this must come first. -->

wasi-js-bindings/test/runner.js

@@ -4,19 +4,22 @@
 
 /**
  * @fileoverview WASI main test runner.
+ * @suppress {moduleLoad} closure compiler can't handle node_modules/.
  */
 
+import {assert, config} from '../../node_modules/chai/chai.js';
+
 // Setup the mocha framework.
 mocha.setup('bdd');
 mocha.checkLeaks();
 
 // Make failure output more useful.
-chai.config.includeStack = true;
-chai.config.showDiff = true;
-chai.config.truncateThreshold = 0;
+config.includeStack = true;
+config.showDiff = true;
+config.truncateThreshold = 0;
 
 // Add a global shortcut to the assert API.
-globalThis['assert'] = chai.assert;
+globalThis['assert'] = assert;
 
 // Catch any random errors before the test runner runs.
 let earlyError = null;