Skip to content

Commit ef54410

Browse files
authored
Merge pull request #1759 from AArnott/fixCompilerWarnings
Fix up compiler warnings
2 parents 7cdddd2 + 22e7c2d commit ef54410

File tree

4 files changed

+14
-2
lines changed

4 files changed

+14
-2
lines changed

LibGit2Sharp/Configuration.cs

-2
Original file line numberDiff line numberDiff line change
@@ -661,7 +661,6 @@ public virtual void Set<T>(string key, T value, ConfigurationLevel level)
661661
/// repo.Config.Add("test.plugin", "first");
662662
/// </para>
663663
/// </summary>
664-
/// <typeparam name="T">The configuration value type</typeparam>
665664
/// <param name="key">The key parts</param>
666665
/// <param name="value">The value</param>
667666
public virtual void Add(string key, string value)
@@ -682,7 +681,6 @@ public virtual void Add(string key, string value)
682681
/// repo.Config.Add("test.plugin", "first");
683682
/// </para>
684683
/// </summary>
685-
/// <typeparam name="T">The configuration value type</typeparam>
686684
/// <param name="key">The key parts</param>
687685
/// <param name="value">The value</param>
688686
/// <param name="level">The configuration file which should be considered as the target of this operation</param>

LibGit2Sharp/GlobalSettings.cs

+4
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,10 @@ public static void SetConfigSearchPaths(ConfigurationLevel level, params string[
351351
Proxy.git_libgit2_opts_set_search_path(level, pathString);
352352
}
353353

354+
/// <summary>
355+
/// Enable or disable strict hash verification.
356+
/// </summary>
357+
/// <param name="enabled">true to enable strict hash verification; false otherwise.</param>
354358
public static void SetStrictHashVerification(bool enabled)
355359
{
356360
Proxy.git_libgit2_opts_enable_strict_hash_verification(enabled);

LibGit2Sharp/Remote.cs

+3
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ internal Remote(RemoteHandle handle, Repository repository)
3434
repository.RegisterForCleanup(this);
3535
}
3636

37+
/// <summary>
38+
/// The finalizer for the <see cref="Remote"/> class.
39+
/// </summary>
3740
~Remote()
3841
{
3942
Dispose(false);

LibGit2Sharp/SmartSubtransport.cs

+7
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,13 @@ public int CertificateCheck(Certificate cert, bool valid, string hostname)
8484
return ret;
8585
}
8686

87+
/// <summary>
88+
/// Acquires credentials.
89+
/// </summary>
90+
/// <param name="cred">Receives the credentials if the operation is successful.</param>
91+
/// <param name="user">The username.</param>
92+
/// <param name="methods">The credential types allowed. The only supported one is <see cref="UsernamePasswordCredentials"/>. May be empty but should not be null.</param>
93+
/// <returns>0 if successful; a non-zero error code that came from <see cref="Proxy.git_transport_smart_credentials"/> otherwise.</returns>
8794
public int AcquireCredentials(out Credentials cred, string user, params Type[] methods)
8895
{
8996
// Convert the user-provided types to libgit2's flags

0 commit comments

Comments
 (0)