Allow clone options bare and ignore_cert

Author: pgaultier

clone.c

@@ -2,25 +2,50 @@
 #include "php_git2_priv.h"
 #include "clone.h"
 
+static void php_git2_git_clone_options_to_array(git_clone_options *options, zval **out TSRMLS_DC)
+{
+    zval *result, *pathspec;
+
+    MAKE_STD_ZVAL(result);
+    array_init(result);
+
+    add_assoc_long_ex(result, ZEND_STRS("version"), options->version);
+    add_assoc_long_ex(result, ZEND_STRS("bare"), options->bare);
+    add_assoc_long_ex(result, ZEND_STRS("ignore_cert_errors"), options->ignore_cert_errors);
+    /* TODO: make other options available */ 
+    *out = result;
+}
+
+static void php_git2_array_to_git_clone_options(git_clone_options *options, zval *array TSRMLS_DC)
+{
+    options->version = php_git2_read_arrval_long2(array, ZEND_STRS("version"), 1 TSRMLS_CC);
+    options->bare = php_git2_read_arrval_long2(array, ZEND_STRS("bare"), 0 TSRMLS_CC);
+    options->ignore_cert_errors = php_git2_read_arrval_long2(array, ZEND_STRS("ignore_cert_errors"), 0 TSRMLS_CC);
+}
+
 /* {{{ proto resource git_clone(string $url, string $localpath[, array $options])
 */
 PHP_FUNCTION(git_clone)
 {
 	char *url, *localpath;
 	int url_len, localpath_len;
-	zval *options;// = GIT_OPTIONS_INIT;
+	zval *opts = NULL;// = GIT_OPTIONS_INIT;
 	php_git2_t *git2;
 	git_repository *repository;
 	int error;
+	git_clone_options options = GIT_CLONE_OPTIONS_INIT;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
-		"ss|a", &url, &url_len, &localpath, &localpath_len, &options) == FAILURE) {
+		"ss|a", &url, &url_len, &localpath, &localpath_len, &opts) == FAILURE) {
 		return;
 	}
 
 	/* TODO(chobie): convert options to git_clone_options */
 
-	error = git_clone(&repository, url, localpath, NULL);
+    php_git2_array_to_git_clone_options(&options, opts TSRMLS_CC);
+    
+
+	error = git_clone(&repository, url, localpath, &options);
 	if (php_git2_check_error(error, "git_clone" TSRMLS_CC)) {
 		RETURN_FALSE
 	}