lib: Deprecate old SELinux APIs, rewrite SELinux documentation (RHBZ#1152825).

Also turns the --selinux option of guestfish, guestmount and
virt-rescue into a no-op -- it didn't work before so this is
effectively no change.

Author: rwmjones

builder/builder.ml

@@ -642,12 +642,6 @@ let main () =
     may g#set_smp cmdline.smp;
     g#set_network cmdline.network;
 
-    (* Make sure to turn SELinux off to avoid awkward interactions
-     * between the appliance kernel and applications/libraries interacting
-     * with SELinux xattrs.
-     *)
-    g#set_selinux false;
-
     (* The output disk is being created, so use cache=unsafe here. *)
     g#add_drive_opts ~format:output_format ~cachemode:"unsafe" output_filename;
 

customize/customize_main.ml

@@ -162,11 +162,6 @@ read the man page virt-customize(1).
     may g#set_memsize memsize;
     may g#set_smp smp;
     g#set_network network;
-    (* Make sure to turn SELinux off to avoid awkward interactions
-     * between the appliance kernel and applications/libraries interacting
-     * with SELinux xattrs.
-     *)
-    g#set_selinux false;
 
     (* Add disks. *)
     add g dryrun;

dib/dib.ml

@@ -634,12 +634,6 @@ let main () =
     may g#set_smp cmdline.smp;
     g#set_network cmdline.network;
 
-    (* Make sure to turn SELinux off to avoid awkward interactions
-     * between the appliance kernel and applications/libraries interacting
-     * with SELinux xattrs.
-     *)
-    g#set_selinux false;
-
     (* Main disk with the built image. *)
     let fmt = "raw" in
     let fn =

tests/selinux/run-test.pl

@@ -105,8 +105,6 @@
 # Create a filesystem that could support xattrs and SELinux labels.
 my $g = Sys::Guestfs->new ();
 
-#$g->set_selinux (1) if $test_type eq "selinux";
-
 $g->add_drive_scratch (256*1024*1024);
 $g->launch ();