Skip to content

Commit fab6fc9

Browse files
committed
fix!: remove CustomEvent export from @libp2p/interface (#2656)
`CustomEvent` is global in Node.js as of `v18.7.0`. We support LTS and Current which means `v20+`, and Electron has upgraded to node 20 so the polyfill isn't necessary any more. BREAKING CHANGE: `@libp2p/interface` no longer exports a `CustomEvent` polyfill
1 parent 301bfc3 commit fab6fc9

File tree

12 files changed

+8
-13
lines changed

12 files changed

+8
-13
lines changed

packages/interface-compliance-tests/src/transport/listen-test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/* eslint max-nested-callbacks: ["error", 8] */
2-
import { CustomEvent, TypedEventEmitter } from '@libp2p/interface'
2+
import { TypedEventEmitter } from '@libp2p/interface'
33
import { expect } from 'aegir/chai'
44
import drain from 'it-drain'
55
import { pipe } from 'it-pipe'

packages/interface/src/event-target.ts

-2
Original file line numberDiff line numberDiff line change
@@ -104,5 +104,3 @@ export class TypedEventEmitter<EventMap extends Record<string, any>> extends Eve
104104
return this.dispatchEvent(new CustomEvent<Detail>(type as string, detail))
105105
}
106106
}
107-
108-
export const CustomEvent = globalThis.CustomEvent

packages/kad-dht/src/kad-dht.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { CodeError, CustomEvent, TypedEventEmitter, contentRoutingSymbol, peerDiscoverySymbol, peerRoutingSymbol, serviceCapabilities, serviceDependencies, start, stop } from '@libp2p/interface'
1+
import { CodeError, TypedEventEmitter, contentRoutingSymbol, peerDiscoverySymbol, peerRoutingSymbol, serviceCapabilities, serviceDependencies, start, stop } from '@libp2p/interface'
22
import drain from 'it-drain'
33
import pDefer from 'p-defer'
44
import { PROTOCOL } from './constants.js'

packages/kad-dht/src/query/events.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
import { CustomEvent } from '@libp2p/interface'
21
import type { MessageType, SendQueryEvent, PeerResponseEvent, DialPeerEvent, AddPeerEvent, ValueEvent, ProviderEvent, QueryErrorEvent, FinalPeerEvent } from '../index.js'
32
import type { PeerId, PeerInfo } from '@libp2p/interface'
43
import type { Libp2pRecord } from '@libp2p/record'

packages/kad-dht/src/topology-listener.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { CustomEvent, TypedEventEmitter } from '@libp2p/interface'
1+
import { TypedEventEmitter } from '@libp2p/interface'
22
import type { KadDHTComponents } from '.'
33
import type { Logger, PeerId, Startable } from '@libp2p/interface'
44

packages/kad-dht/test/query-self.spec.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
/* eslint-env mocha */
22

3-
import { CustomEvent } from '@libp2p/interface'
43
import { defaultLogger } from '@libp2p/logger'
54
import { createEd25519PeerId } from '@libp2p/peer-id-factory'
65
import { expect } from 'aegir/chai'

packages/kad-dht/test/routing-table.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
/* eslint-env mocha */
22

3-
import { TypedEventEmitter, CustomEvent, stop, start } from '@libp2p/interface'
3+
import { TypedEventEmitter, stop, start } from '@libp2p/interface'
44
import { mockConnectionManager } from '@libp2p/interface-compliance-tests/mocks'
55
import { defaultLogger } from '@libp2p/logger'
66
import { PeerSet } from '@libp2p/peer-collections'

packages/libp2p/src/libp2p.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { unmarshalPrivateKey, unmarshalPublicKey } from '@libp2p/crypto/keys'
2-
import { contentRoutingSymbol, CodeError, TypedEventEmitter, CustomEvent, setMaxListeners, peerDiscoverySymbol, peerRoutingSymbol } from '@libp2p/interface'
2+
import { contentRoutingSymbol, CodeError, TypedEventEmitter, setMaxListeners, peerDiscoverySymbol, peerRoutingSymbol } from '@libp2p/interface'
33
import { defaultLogger } from '@libp2p/logger'
44
import { PeerSet } from '@libp2p/peer-collections'
55
import { peerIdFromString } from '@libp2p/peer-id'

packages/peer-discovery-mdns/src/mdns.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { CustomEvent, TypedEventEmitter, peerDiscoverySymbol, serviceCapabilities } from '@libp2p/interface'
1+
import { TypedEventEmitter, peerDiscoverySymbol, serviceCapabilities } from '@libp2p/interface'
22
import multicastDNS from 'multicast-dns'
33
import * as query from './query.js'
44
import { stringGen } from './utils.js'

packages/peer-discovery-mdns/test/compliance.spec.ts

-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
/* eslint-env mocha */
22

3-
import { CustomEvent } from '@libp2p/interface'
43
import tests from '@libp2p/interface-compliance-tests/peer-discovery'
54
import { defaultLogger } from '@libp2p/logger'
65
import { createEd25519PeerId } from '@libp2p/peer-id-factory'

packages/pubsub/src/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
* ```
3131
*/
3232

33-
import { CodeError, TypedEventEmitter, CustomEvent, TopicValidatorResult } from '@libp2p/interface'
33+
import { CodeError, TypedEventEmitter, TopicValidatorResult } from '@libp2p/interface'
3434
import { PeerMap, PeerSet } from '@libp2p/peer-collections'
3535
import { pipe } from 'it-pipe'
3636
import Queue from 'p-queue'

packages/pubsub/src/peer-streams.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { TypedEventEmitter, CustomEvent } from '@libp2p/interface'
1+
import { TypedEventEmitter } from '@libp2p/interface'
22
import { closeSource } from '@libp2p/utils/close-source'
33
import * as lp from 'it-length-prefixed'
44
import { pipe } from 'it-pipe'

0 commit comments

Comments
 (0)