Skip to content

Commit

Permalink
ci(cache): only save caches on master branch (#3249)
Browse files Browse the repository at this point in the history
Previously, we would always save certain smaller caches like clippy etc on each PR. This still amounts to a lot of caches. With this patch, we conditionally only save them when the workflow is run on the master branch. This gives most pull requests a good base to work with to speed them up significantly without us keeping around a lot of caches and have GitHub invalidate them constantly.

On master, the condition evaluates to `true` which saves the cache: https://github.com/thomaseizinger/rust-libp2p/actions/runs/3699904381/jobs/6267774899#step:5:3
On pull-requests, the condition evaluates to `false` which skips saving it: https://github.com/thomaseizinger/rust-libp2p/actions/runs/3700055536/jobs/6268096357#step:4:3
  • Loading branch information
thomaseizinger authored Dec 17, 2022
1 parent e9d5a30 commit 56398cb
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ jobs:
target: ${{ matrix.target }}

- uses: Swatinem/rust-cache@359a70e43a0bb8a13953b04a90f76428b4959bb6 # v2.2.0
with:
save-if: ${{ github.ref == 'refs/heads/master' }}

- run: cargo check --package libp2p --all-features --target=${{ matrix.target }}

Expand All @@ -141,6 +143,8 @@ jobs:
override: true

- uses: Swatinem/rust-cache@359a70e43a0bb8a13953b04a90f76428b4959bb6 # v2.2.0
with:
save-if: ${{ github.ref == 'refs/heads/master' }}

- run: cargo check --package libp2p --features="${{ matrix.features }}"

Expand All @@ -162,6 +166,8 @@ jobs:
override: true

- uses: Swatinem/rust-cache@359a70e43a0bb8a13953b04a90f76428b4959bb6 # v2.2.0
with:
save-if: ${{ github.ref == 'refs/heads/master' }}

- name: Check rustdoc links
run: RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links --deny warnings" cargo doc --verbose --workspace --no-deps --all-features --document-private-items
Expand Down Expand Up @@ -191,6 +197,8 @@ jobs:
components: clippy

- uses: Swatinem/rust-cache@359a70e43a0bb8a13953b04a90f76428b4959bb6 # v2.2.0
with:
save-if: ${{ github.ref == 'refs/heads/master' }}

- name: Run cargo clippy
uses: actions-rs/cargo@844f36862e911db73fe0815f00a4a2602c279505 # v1.0.3
Expand All @@ -215,6 +223,8 @@ jobs:
override: true

- uses: Swatinem/rust-cache@359a70e43a0bb8a13953b04a90f76428b4959bb6 # v2.2.0
with:
save-if: ${{ github.ref == 'refs/heads/master' }}

- name: Run ipfs-kad example
run: RUST_LOG=libp2p_swarm=debug,libp2p_kad=trace,libp2p_tcp=debug cargo run --example ipfs-kad --features full
Expand Down

0 comments on commit 56398cb

Please sign in to comment.