Skip to content

Commit a172af3

Browse files
SoapGentooerikd
authored andcommitted
Use $(...) instead of @...@ for precious variables
* AC_SUBST creates the variable assignment transparently: var = @var@ hence there is no need to directly include @var@-style replacements, which cannot be overridden when running Make.
1 parent 3224a2a commit a172af3

File tree

3 files changed

+13
-17
lines changed

3 files changed

+13
-17
lines changed

examples/Makefile.am

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,19 @@ endif
88
check_PROGRAMS = varispeed-play timewarp-file
99

1010
SAMPLERATEDIR =../src
11-
AM_CPPFLAGS = -I$(srcdir)/$(SAMPLERATEDIR) @OS_SPECIFIC_INCLUDES@
12-
13-
OS_SPECIFIC_LINKS = @OS_SPECIFIC_LINKS@
14-
15-
SNDFILE_LIBS = @SNDFILE_LIBS@ @ALSA_LIBS@
16-
AM_CFLAGS = @SNDFILE_CFLAGS@
11+
AM_CPPFLAGS = -I$(srcdir)/$(SAMPLERATEDIR) $(OS_SPECIFIC_INCLUDES)
12+
AM_CFLAGS = $(SNDFILE_CFLAGS)
1713

1814
#===============================================================================
1915

2016
if HAVE_LIBSNDFILE
2117
sndfile_resample_SOURCES = sndfile-resample.c
22-
sndfile_resample_LDADD = $(SAMPLERATEDIR)/libsamplerate.la $(SNDFILE_LIBS)
18+
sndfile_resample_LDADD = $(SAMPLERATEDIR)/libsamplerate.la $(SNDFILE_LIBS) $(ALSA_LIBS)
2319
endif
2420

2521
varispeed_play_SOURCES = varispeed-play.c audio_out.c audio_out.h
26-
varispeed_play_LDADD = $(SAMPLERATEDIR)/libsamplerate.la $(SNDFILE_LIBS) $(OS_SPECIFIC_LINKS)
22+
varispeed_play_LDADD = $(SAMPLERATEDIR)/libsamplerate.la $(SNDFILE_LIBS) $(ALSA_LIBS) $(OS_SPECIFIC_LINKS)
2723

2824
timewarp_file_SOURCES = timewarp-file.c
29-
timewarp_file_LDADD = $(SAMPLERATEDIR)/libsamplerate.la $(SNDFILE_LIBS)
25+
timewarp_file_LDADD = $(SAMPLERATEDIR)/libsamplerate.la $(SNDFILE_LIBS) $(ALSA_LIBS)
3026

src/Makefile.am

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ noinst_HEADERS = common.h float_cast.h $(COEFF_HDRS)
1515
SRC_SOURCES = samplerate.c src_sinc.c $(COEFF_HDRS) src_zoh.c src_linear.c
1616

1717
# MinGW requires -no-undefined if a DLL is to be built.
18-
libsamplerate_la_LDFLAGS = -no-undefined -version-info @SHARED_VERSION_INFO@ @SHLIB_VERSION_ARG@
18+
libsamplerate_la_LDFLAGS = -no-undefined -version-info $(SHARED_VERSION_INFO) $(SHLIB_VERSION_ARG)
1919
libsamplerate_la_SOURCES = $(SRC_SOURCES) $(noinst_HEADERS)
2020
libsamplerate_la_LIBADD = -lm
2121

tests/Makefile.am

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,15 +39,15 @@ reset_test_SOURCES = reset_test.c util.c util.h
3939
reset_test_LDADD = $(SAMPLRATEDIR)/libsamplerate.la
4040

4141
multi_channel_test_SOURCES = multi_channel_test.c util.c calc_snr.c
42-
multi_channel_test_CFLAGS = @FFTW3_CFLAGS@
42+
multi_channel_test_CFLAGS = $(FFTW3_CFLAGS)
4343
multi_channel_test_LDADD = $(SAMPLRATEDIR)/libsamplerate.la $(FFTW3_LIBS)
4444

4545
snr_bw_test_SOURCES = snr_bw_test.c calc_snr.c util.c util.h
46-
snr_bw_test_CFLAGS = @FFTW3_CFLAGS@
46+
snr_bw_test_CFLAGS = $(FFTW3_CFLAGS)
4747
snr_bw_test_LDADD = $(SAMPLRATEDIR)/libsamplerate.la $(FFTW3_LIBS)
4848

4949
callback_test_SOURCES = callback_test.c util.c util.h
50-
callback_test_CFLAGS = @FFTW3_CFLAGS@
50+
callback_test_CFLAGS = $(FFTW3_CFLAGS)
5151
callback_test_LDADD = $(SAMPLRATEDIR)/libsamplerate.la
5252

5353
float_short_test_SOURCES = float_short_test.c util.c util.h
@@ -57,19 +57,19 @@ downsample_test_SOURCES = downsample_test.c util.c util.h
5757
downsample_test_LDADD = $(SAMPLRATEDIR)/libsamplerate.la
5858

5959
varispeed_test_SOURCES = varispeed_test.c util.c util.h calc_snr.c
60-
varispeed_test_CFLAGS = @FFTW3_CFLAGS@
60+
varispeed_test_CFLAGS = $(FFTW3_CFLAGS)
6161
varispeed_test_LDADD = $(SAMPLRATEDIR)/libsamplerate.la $(FFTW3_LIBS)
6262

6363
# This program is for evaluating other sample rate converters.
6464

65-
throughput_test_CFLAGS = $(AM_CFLAGS) @FFTW3_CFLAGS@
65+
throughput_test_CFLAGS = $(AM_CFLAGS) $(FFTW3_CFLAGS)
6666
throughput_test_SOURCES = throughput_test.c util.c calc_snr.c
6767
throughput_test_LDADD = $(SAMPLRATEDIR)/libsamplerate.la $(FFTW3_LIBS)
6868

69-
multichan_throughput_test_CFLAGS = $(AM_CFLAGS) @FFTW3_CFLAGS@
69+
multichan_throughput_test_CFLAGS = $(AM_CFLAGS) $(FFTW3_CFLAGS)
7070
multichan_throughput_test_SOURCES = multichan_throughput_test.c util.c calc_snr.c
7171
multichan_throughput_test_LDADD = $(SAMPLRATEDIR)/libsamplerate.la $(FFTW3_LIBS)
7272

7373
src_evaluate_SOURCES = src-evaluate.c calc_snr.c util.c
74-
src_evaluate_CFLAGS = @SNDFILE_CFLAGS@ @FFTW3_CFLAGS@
74+
src_evaluate_CFLAGS = $(SNDFILE_CFLAGS) $(FFTW3_CFLAGS)
7575
src_evaluate_LDADD = $(SNDFILE_LIBS) $(FFTW3_LIBS)

0 commit comments

Comments
 (0)